Summary: | Add Private API for creating a WebKit1 WebSerializedJSValue from the internal representation of a WebKit2 WebSerializedScriptValue | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jessie Berlin <jberlin> | ||||||
Component: | WebKit2 | Assignee: | Jessie Berlin <jberlin> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aroben, jberlin, sam, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Jessie Berlin
2010-10-07 18:59:00 PDT
Created attachment 70189 [details]
Adds the Private APIs to create a WebKit1 WebSerializedJSValue from the internal representation of a WebKit2 WebSerializedScriptValue
Created attachment 70192 [details]
Fixes style issue in previous patch
Attachment 70189 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit/mac/WebView/WebSerializedJSValuePrivate.h:31: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 1 in 18 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 70192 [details] Fixes style issue in previous patch View in context: https://bugs.webkit.org/attachment.cgi?id=70192&action=review > WebKit2/Shared/API/c/WKSerializedScriptValuePrivate.h:35 > +WK_EXPORT void* WKSerializedScriptValueGetInternalRepresentation(WKSerializedScriptValueRef); We usually give a parameter name here. (In reply to comment #4) > (From update of attachment 70192 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=70192&action=review > > > WebKit2/Shared/API/c/WKSerializedScriptValuePrivate.h:35 > > +WK_EXPORT void* WKSerializedScriptValueGetInternalRepresentation(WKSerializedScriptValueRef); > > We usually give a parameter name here. Done. Thanks for the review! Comment on attachment 70192 [details] Fixes style issue in previous patch Committed in r69415 http://trac.webkit.org/changeset/69415 |