Bug 47390

Summary: Add Private API for creating a WebKit1 WebSerializedJSValue from the internal representation of a WebKit2 WebSerializedScriptValue
Product: WebKit Reporter: Jessie Berlin <jberlin@webkit.org>
Component: WebKit2Assignee: Jessie Berlin <jberlin@webkit.org>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben@webkit.org, jberlin@webkit.org, sam@webkit.org, webkit.review.bot@gmail.com
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Adds the Private APIs to create a WebKit1 WebSerializedJSValue from the internal representation of a WebKit2 WebSerializedScriptValue
none
Fixes style issue in previous patch none

Description From 2010-10-07 18:59:00 PST
Both the WebKit1 and WebKit2 types have the same underlying internal representation: WebCore::SerializedScriptValue.
------- Comment #1 From 2010-10-07 19:33:11 PST -------
Created an attachment (id=70189) [details]
Adds the Private APIs to create a WebKit1 WebSerializedJSValue from the internal representation of a WebKit2 WebSerializedScriptValue
------- Comment #2 From 2010-10-07 19:37:31 PST -------
Created an attachment (id=70192) [details]
Fixes style issue in previous patch
------- Comment #3 From 2010-10-07 19:38:43 PST -------
Attachment 70189 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit/mac/WebView/WebSerializedJSValuePrivate.h:31:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
------- Comment #4 From 2010-10-08 10:39:38 PST -------
(From update of attachment 70192 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=70192&action=review

> WebKit2/Shared/API/c/WKSerializedScriptValuePrivate.h:35
> +WK_EXPORT void* WKSerializedScriptValueGetInternalRepresentation(WKSerializedScriptValueRef);

We usually give a parameter name here.
------- Comment #5 From 2010-10-08 12:02:54 PST -------
(In reply to comment #4)
> (From update of attachment 70192 [details] [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=70192&action=review
> 
> > WebKit2/Shared/API/c/WKSerializedScriptValuePrivate.h:35
> > +WK_EXPORT void* WKSerializedScriptValueGetInternalRepresentation(WKSerializedScriptValueRef);
> 
> We usually give a parameter name here.

Done.

Thanks for the review!
------- Comment #6 From 2010-10-08 12:54:54 PST -------
(From update of attachment 70192 [details])
Committed in r69415
http://trac.webkit.org/changeset/69415