Bug 47338

Summary: [GTK] Use draw instead of expose_event in WebView when building with gtk3
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Use draw instead of expose_event none

Carlos Garcia Campos
Reported 2010-10-07 04:11:53 PDT
expose_event has been removed in gtk3
Attachments
Use draw instead of expose_event (3.36 KB, patch)
2010-10-07 04:28 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2010-10-07 04:28:06 PDT
Created attachment 70066 [details] Use draw instead of expose_event
Xan Lopez
Comment 2 2010-10-07 04:40:02 PDT
Comment on attachment 70066 [details] Use draw instead of expose_event Good!
WebKit Commit Bot
Comment 3 2010-10-07 05:57:54 PDT
Comment on attachment 70066 [details] Use draw instead of expose_event Clearing flags on attachment: 70066 Committed r69302: <http://trac.webkit.org/changeset/69302>
WebKit Commit Bot
Comment 4 2010-10-07 05:57:58 PDT
All reviewed patches have been landed. Closing bug.
Martin Robinson
Comment 5 2010-10-07 10:44:29 PDT
Instead of duplicating the entire method the event handlers should be small shims which call a helper function.
Carlos Garcia Campos
Comment 6 2010-10-08 05:37:58 PDT
(In reply to comment #5) > Instead of duplicating the entire method the event handlers should be small shims which call a helper function. I've done something like that in patch attached to bug #47411
Note You need to log in before you can comment on or make changes to this bug.