Bug 47307

Summary: Remove support for ANGLE SH_VERSION <= 100
Product: WebKit Reporter: Alok Priyadarshi <alokp>
Component: WebGLAssignee: Alok Priyadarshi <alokp>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jamesr, kbr, zmo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 47381    
Bug Blocks:    
Attachments:
Description Flags
proposed patch none

Alok Priyadarshi
Reported 2010-10-06 15:08:28 PDT
Now that ANGLE version has been rolled to r443 we do not need to support SH_VERSION <= 100. The code that's been affected is in ${WebKitRoot}/WebKit/chromium/src/WebGraphicsContext3DDefaultImpl.cpp for functions angleCreateCompilers angleValidateShaderSource()
Attachments
proposed patch (2.61 KB, patch)
2010-10-06 15:17 PDT, Alok Priyadarshi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alok Priyadarshi
Comment 1 2010-10-06 15:17:13 PDT
Created attachment 69998 [details] proposed patch
Kenneth Russell
Comment 2 2010-10-06 15:56:38 PDT
Comment on attachment 69998 [details] proposed patch You will need to first roll forward the Chromium deps in WebKit (used to build the DumpRenderTree tool, which depends on this code) to a version containing the rolled-forward ANGLE. I suggest filing a separate bug for that and making this one dependent on it. The file is WebKit/chromium/DEPS, chromium_rev. You can verify that the roll-forward succeeds via "build-webkit --chromium --debug". Mark this r? again once this is done.
Zhenyao Mo
Comment 3 2010-10-07 18:19:20 PDT
have you rolled already? If not, could you include chroium r61902?
Zhenyao Mo
Comment 4 2010-10-07 19:54:19 PDT
Ignore this. I just rolled myself. (In reply to comment #3) > have you rolled already? If not, could you include chroium r61902?
Alok Priyadarshi
Comment 5 2010-10-12 15:35:40 PDT
The Chromium DEPS in WebKit has been rolled forward to pull the latest version of ANGLE.
Kenneth Russell
Comment 6 2010-10-12 18:07:20 PDT
Comment on attachment 69998 [details] proposed patch Thanks. Looks good to me.
WebKit Commit Bot
Comment 7 2010-10-12 18:23:47 PDT
Comment on attachment 69998 [details] proposed patch Clearing flags on attachment: 69998 Committed r69627: <http://trac.webkit.org/changeset/69627>
WebKit Commit Bot
Comment 8 2010-10-12 18:23:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.