Bug 47296

Summary: Sunspider-compare-results does not use the --root passed in variable
Product: WebKit Reporter: Lucas Forschler <lforschler>
Component: Tools / TestsAssignee: Lucas Forschler <lforschler>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, bweinstein, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Fix the sunspider-compare-results function to actually use the value for $root passed in. none

Lucas Forschler
Reported 2010-10-06 12:55:12 PDT
in the GetOptions function, a value for root is never set. Thus, root is always empty. In buildJSC, if !(defined($root) always returns false.
Attachments
Fix the sunspider-compare-results function to actually use the value for $root passed in. (1.23 KB, patch)
2010-10-06 13:03 PDT, Lucas Forschler 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Lucas Forschler
Comment 1 2010-10-06 13:03:32 PDT
Created attachment 69980 [details] Fix the sunspider-compare-results function to actually use the value for $root passed in.
WebKit Commit Bot
Comment 2 2010-10-06 18:06:56 PDT
Comment on attachment 69980 [details] Fix the sunspider-compare-results function to actually use the value for $root passed in. Clearing flags on attachment: 69980 Committed r69264: <http://trac.webkit.org/changeset/69264>
WebKit Commit Bot
Comment 3 2010-10-06 18:07:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.