Bug 47280 – [Qt] RunLoop implementation for WTR

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Balazs Kelemen]

WTR needs a runloop for being functional. WTR is a little bit tricky because the event loop
is allowed to run only while we are in the TestController::runUntil. While we are
in the event loop we must check a global variable and stop the loop when it is becoming true.
Our friend will be QEventLoop!

[Balazs Kelemen]

Created attachment 69963 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 69963 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69963&action=review

> WebKitTools/WebKitTestRunner/qt/TestControllerQt.cpp:38
> +class RunUntilLoop : public QObject {

Run until what? a condition? RunSingle?

> WebKitTools/WebKitTestRunner/qt/TestControllerQt.cpp:42
> +    static void start(bool& done)

ah seems to be a condition, I guess RunUntilConditionLoop would be a better name.

> WebKitTools/WebKitTestRunner/qt/main.cpp:51
> +        m_controller = new WTR::TestController(m_argc, const_cast<const char**>(m_argv));

leaking m_controller?

[Balazs Kelemen]

> 
> > WebKitTools/WebKitTestRunner/qt/main.cpp:51
> > +        m_controller = new WTR::TestController(m_argc, const_cast<const char**>(m_argv));
> 
> leaking m_controller?

No, it is deleted in the destructor :)

[Balazs Kelemen]

I will do the renaming before commit.

[Balazs Kelemen]

Could not be committed before the dependency lands.

[Andras Becsi]

Comment on attachment 69963 [details]
Patch

Clearing flags on attachment: 69963

Committed r69253: <http://trac.webkit.org/changeset/69253>

[Andras Becsi]

All reviewed patches have been landed.  Closing bug.