Summary: | [Qt] RunLoop implementation for WTR | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Balazs Kelemen <kbalazs> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abecsi | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | All | ||||||
Bug Depends on: | 45393 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Balazs Kelemen
2010-10-06 10:57:31 PDT
Created attachment 69963 [details]
Patch
Comment on attachment 69963 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69963&action=review > WebKitTools/WebKitTestRunner/qt/TestControllerQt.cpp:38 > +class RunUntilLoop : public QObject { Run until what? a condition? RunSingle? > WebKitTools/WebKitTestRunner/qt/TestControllerQt.cpp:42 > + static void start(bool& done) ah seems to be a condition, I guess RunUntilConditionLoop would be a better name. > WebKitTools/WebKitTestRunner/qt/main.cpp:51 > + m_controller = new WTR::TestController(m_argc, const_cast<const char**>(m_argv)); leaking m_controller? >
> > WebKitTools/WebKitTestRunner/qt/main.cpp:51
> > + m_controller = new WTR::TestController(m_argc, const_cast<const char**>(m_argv));
>
> leaking m_controller?
No, it is deleted in the destructor :)
I will do the renaming before commit. Could not be committed before the dependency lands. Comment on attachment 69963 [details] Patch Clearing flags on attachment: 69963 Committed r69253: <http://trac.webkit.org/changeset/69253> All reviewed patches have been landed. Closing bug. |