Bug 47258

Summary:

Incorrect order of deleting objects

Product:

WebKit

Reporter:

Lukasz Slachciak <l.slachciak>

Component:

WebKit EFL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

barbieri, gyuyoung.kim, l.slachciak, rakuco

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
Order fix	abarth: review-

Lukasz Slachciak

Reported 2010-10-06 04:53:03 PDT

In _ewk_view_smart_del function there is incorrect order of deleting objects. I think that first we should release private data next the parent one. Attached patch fixes this issue and corrects "includes" order so check-webkit-style will not fail for ewk_view.cpp

Attachments
Order fix (1.44 KB, patch) 2010-10-06 05:03 PDT, Lukasz Slachciak	abarth: review-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Lukasz Slachciak

Comment 1 2010-10-06 05:03:26 PDT

Created attachment 69926 [details] Order fix

Adam Barth

Comment 2 2010-10-10 12:35:31 PDT

Comment on attachment 69926 [details] Order fix We need a test.

Gustavo Sverzut Barbieri

Comment 3 2011-09-14 10:32:52 PDT

r- It does not fix anything as _parent_sc.del is evas_object_smart_clipped_smart_del() (http://svn.enlightenment.org/svn/e/trunk/evas/src/lib/canvas/evas_object_smart_clipped.c) and it does not even know about this private data (which is a member of actual smart data stored in the object and deleted by that function). _ewk_view_priv_del() does not touch the object deleted by _parent_sc.del(). And if it did, it would fail as the object is being deleted and shouldn't be touched.

Note You need to log in before you can comment on or make changes to this bug.