Bug 47234

Summary: [BREWMP] Translate key code in PlatformKeyboardEvent with IKeysMapping
Product: WebKit Reporter: Kim, kyusun <maniagoon>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, skyul
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Bug Depends on:    
Bug Blocks: 33564    
Attachments:
Description Flags
Patch none

Kim, kyusun
Reported 2010-10-05 17:48:02 PDT
Brew MP devices have a variey of key configurations and use modifiers to input capital letters, symbols and special characters. Use IKeysMapping to translate key code.
Attachments
Patch (3.24 KB, patch)
2010-10-05 17:50 PDT, Kim, kyusun 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kim, kyusun
Comment 1 2010-10-05 17:50:26 PDT
Created attachment 69871 [details] Patch
Kwang Yul Seo
Comment 2 2010-10-05 18:07:30 PDT
IKeysMapping maps an AVK key code and modifier combination to the intended character. For example, AVK_RALT + 'e' becomes 1 and AVK_LSHIFT + 'a' becomes 'A' in a certain device. Because kep mappings are different among devices, we need IKeysMapping abstraction.
Kent Tamura
Comment 3 2010-10-05 18:35:55 PDT
Comment on attachment 69871 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69871&action=review > WebCore/platform/brew/PlatformKeyboardEventBrew.cpp:160 > + if ((m_type == Char) && modifiers) { nit: Checking "m_type" and checking "type" are mixed in the constructor. It's confusing.
WebKit Commit Bot
Comment 4 2010-10-05 20:58:28 PDT
Comment on attachment 69871 [details] Patch Clearing flags on attachment: 69871 Committed r69175: <http://trac.webkit.org/changeset/69175>
WebKit Commit Bot
Comment 5 2010-10-05 20:58:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.