Summary: | [BREWMP] Translate key code in PlatformKeyboardEvent with IKeysMapping | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kim, kyusun <maniagoon> | ||||
Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, skyul | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | Other | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 33564 | ||||||
Attachments: |
|
Description
Kim, kyusun
2010-10-05 17:48:02 PDT
Created attachment 69871 [details]
Patch
IKeysMapping maps an AVK key code and modifier combination to the intended character. For example, AVK_RALT + 'e' becomes 1 and AVK_LSHIFT + 'a' becomes 'A' in a certain device. Because kep mappings are different among devices, we need IKeysMapping abstraction. Comment on attachment 69871 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69871&action=review > WebCore/platform/brew/PlatformKeyboardEventBrew.cpp:160 > + if ((m_type == Char) && modifiers) { nit: Checking "m_type" and checking "type" are mixed in the constructor. It's confusing. Comment on attachment 69871 [details] Patch Clearing flags on attachment: 69871 Committed r69175: <http://trac.webkit.org/changeset/69175> All reviewed patches have been landed. Closing bug. |