Bug 47234

Summary:

[BREWMP] Translate key code in PlatformKeyboardEvent with IKeysMapping

Product:

WebKit

Reporter:

Kim, kyusun <maniagoon>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, skyul

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Other

Bug Depends on:

Bug Blocks:

33564

Attachments:

Description	Flags
Patch	none

Description Kim, kyusun 2010-10-05 17:48:02 PDT

Brew MP devices have a variey of key configurations and use modifiers to input capital letters, symbols and special characters. Use IKeysMapping to translate key code.

Comment 1 Kim, kyusun 2010-10-05 17:50:26 PDT

Created attachment 69871 [details]
Patch

Comment 2 Kwang Yul Seo 2010-10-05 18:07:30 PDT

IKeysMapping maps an AVK key code and modifier combination to the intended character. For example, AVK_RALT + 'e' becomes 1 and AVK_LSHIFT + 'a' becomes 'A' in a certain device. Because kep mappings are different among devices, we need IKeysMapping abstraction.

Comment 3 Kent Tamura 2010-10-05 18:35:55 PDT

Comment on attachment 69871 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69871&action=review

> WebCore/platform/brew/PlatformKeyboardEventBrew.cpp:160
> +    if ((m_type == Char) && modifiers) {

nit: Checking "m_type" and checking "type" are mixed in the constructor.  It's confusing.

Comment 4 WebKit Commit Bot 2010-10-05 20:58:28 PDT

Comment on attachment 69871 [details]
Patch

Clearing flags on attachment: 69871

Committed r69175: <http://trac.webkit.org/changeset/69175>

Comment 5 WebKit Commit Bot 2010-10-05 20:58:33 PDT

All reviewed patches have been landed.  Closing bug.