Bug 47171

Summary: Extraneous unsupported InputSpeechButtonGraphic in QWebSettings
Product: WebKit Reporter: Keith Kyzivat <kamaji>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch removing InputSpeechButtonGraphic in QtWebkit 2.1 none

Keith Kyzivat
Reported 2010-10-05 06:12:50 PDT
QWebSettings WebGraphic enum had an entry added for Input Speech element support. This feature was added to trunk back in July, and merged into QtWebkit 2.1 branch. It currently not finished, and not supported in QtWebKit 2.1. This is an extraneous and unneeded change to the QtWebKit 2.1 API, and is not supported nor needed. After a review of the QtWebkit 2.1 API changes, it was a candidate for removal. I have looked at the changes, and have determined that it is easy to remove, so it should be removed. Attached you'll find the patch that removes this. It should be applied to the QtWebkit 2.1 branch.
Attachments
Patch removing InputSpeechButtonGraphic in QtWebkit 2.1 (2.40 KB, patch)
2010-10-05 06:16 PDT, Keith Kyzivat 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Keith Kyzivat
Comment 1 2010-10-05 06:16:07 PDT
Created attachment 69774 [details] Patch removing InputSpeechButtonGraphic in QtWebkit 2.1
Keith Kyzivat
Comment 2 2010-10-05 09:32:49 PDT
This bug can be marked invalid.
Note You need to log in before you can comment on or make changes to this bug.