Summary: | Removed unused callback in webkitwebview | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | commit-queue, xan.lopez | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | PC | ||||||||||||
OS: | Linux | ||||||||||||
Attachments: |
|
Comment on attachment 69639 [details]
Remove unused callback
Looks good, but we need the ChangeLog.
Created attachment 70063 [details]
Updated patch
It just adds a changelog entry
Comment on attachment 70063 [details]
Updated patch
I think it's worth explaining in the comment why it's never called. We reuse the same menu always, holding a ref to it, so it's not destroyed when withdrawn by the user.
Created attachment 70237 [details]
Another update
Includes the explation suggested by Xan to ChangeLog
Created attachment 70239 [details]
Another iteration
I forgot the [GTK] prefix in the changelog, sorry.
Comment on attachment 70239 [details]
Another iteration
Great, thanks.
Comment on attachment 70239 [details] Another iteration Clearing flags on attachment: 70239 Committed r69444: <http://trac.webkit.org/changeset/69444> All reviewed patches have been landed. Closing bug. |
Created attachment 69639 [details] Remove unused callback In webkit_web_view_forward_context_menu_event() a callback is connected for the destroy signal of the popup menu, but the menu is never destroyed so the callback never gets called. If it were called it would crash since NULL is passed as user_data, so I think it's safe to just remove the callback.