Bug 47092

Summary: Removed unused callback in webkitwebview
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Remove unused callback
xan.lopez: review-
Updated patch
none
Another update
none
Another iteration none

Carlos Garcia Campos
Reported 2010-10-04 08:55:51 PDT
Created attachment 69639 [details] Remove unused callback In webkit_web_view_forward_context_menu_event() a callback is connected for the destroy signal of the popup menu, but the menu is never destroyed so the callback never gets called. If it were called it would crash since NULL is passed as user_data, so I think it's safe to just remove the callback.
Attachments
Remove unused callback (1.12 KB, patch)
2010-10-04 08:55 PDT, Carlos Garcia Campos 		xan.lopez: review-
DetailsFormatted DiffDiff
Updated patch (2.00 KB, patch)
2010-10-07 03:05 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Another update (1.91 KB, patch)
2010-10-08 06:20 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Another iteration (1.91 KB, patch)
2010-10-08 06:23 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Xan Lopez
Comment 1 2010-10-05 03:08:56 PDT
Comment on attachment 69639 [details] Remove unused callback Looks good, but we need the ChangeLog.
Carlos Garcia Campos
Comment 2 2010-10-07 03:05:43 PDT
Created attachment 70063 [details] Updated patch It just adds a changelog entry
Xan Lopez
Comment 3 2010-10-07 04:59:03 PDT
Comment on attachment 70063 [details] Updated patch I think it's worth explaining in the comment why it's never called. We reuse the same menu always, holding a ref to it, so it's not destroyed when withdrawn by the user.
Carlos Garcia Campos
Comment 4 2010-10-08 06:20:09 PDT
Created attachment 70237 [details] Another update Includes the explation suggested by Xan to ChangeLog
Carlos Garcia Campos
Comment 5 2010-10-08 06:23:03 PDT
Created attachment 70239 [details] Another iteration I forgot the [GTK] prefix in the changelog, sorry.
Xan Lopez
Comment 6 2010-10-09 02:39:50 PDT
Comment on attachment 70239 [details] Another iteration Great, thanks.
WebKit Commit Bot
Comment 7 2010-10-09 03:28:31 PDT
Comment on attachment 70239 [details] Another iteration Clearing flags on attachment: 70239 Committed r69444: <http://trac.webkit.org/changeset/69444>
WebKit Commit Bot
Comment 8 2010-10-09 03:28:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.