Bug 47076

Summary: [cairo] Move some cairo functions to the CairoUtilities
Product: WebKit Reporter: Alejandro G. Castro <alex>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 45902    
Attachments:
Description Flags
Proposed patch mrobinson: review+

Alejandro G. Castro
Reported 2010-10-04 03:25:01 PDT
We need to move some cairo functions to the CairoUtilities so we can use them outside GraphicsContextCairo.
Attachments
Proposed patch (12.62 KB, patch)
2010-10-04 04:13 PDT, Alejandro G. Castro 		mrobinson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alejandro G. Castro
Comment 1 2010-10-04 04:13:48 PDT
Created attachment 69613 [details] Proposed patch
Martin Robinson
Comment 2 2010-10-04 07:54:44 PDT
Comment on attachment 69613 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=69613&action=review Looks great! Please fix the following small issues before landing though. > WebCore/platform/graphics/cairo/CairoUtilities.cpp:73 > +// We apply the pending path built via addPath to the Cairo context > +// lazily. This prevents interaction between the path and other routines > +// such as fillRect. This comment doesn't make quite as much sense now that this function is shared between different source files. It's probably safe just to remove it. > WebCore/platform/graphics/cairo/CairoUtilities.cpp:122 > +void drawPatternCairo(cairo_t* cr, cairo_surface_t* image, const IntSize& imageSize, const FloatRect& tileRect, I think it you should call this drawPatternToCairoContext to match the name of the other helper functions.
Alejandro G. Castro
Comment 3 2010-10-04 08:25:13 PDT
Landed with the suggested modifications http://trac.webkit.org/changeset/69015
Note You need to log in before you can comment on or make changes to this bug.