Summary: | [GTK] REGRESSION: FreeType backend does not respect XSettings font settings after r68558 | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Martin Robinson <mrobinson> | ||||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | Keywords: | Gtk | ||||||||
Priority: | P3 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | Linux | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 47134 | ||||||||||
Attachments: |
|
Description
Martin Robinson
2010-10-01 17:39:58 PDT
Created attachment 69550 [details]
Patch for this issue
Created attachment 70129 [details]
Patch updated to ToT
Comment on attachment 70129 [details] Patch updated to ToT View in context: https://bugs.webkit.org/attachment.cgi?id=70129&action=review The patch looks fine, I have just one minor comment. > WebCore/ChangeLog:11 > + override the setting if it was previously off. Why is that the case? What would happen if we turn it on again? > WebCore/platform/graphics/cairo/FontPlatformDataFreeType.cpp:93 > + cairo_font_options_set_antialias(options, CAIRO_ANTIALIAS_GRAY); The else if comes a bit unexpected. Could you move the comment to the top? Created attachment 70753 [details]
Patch with updated comments
Comment on attachment 70753 [details]
Patch with updated comments
Looks good.
Committed r69786: <http://trac.webkit.org/changeset/69786> |