Bug 4701

Summary: Enable filter tests
Product: WebKit Reporter: Tobias Lidskog <tobiaslidskog>
Component: SVGAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P4    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
add null checks
eric: review+
sligthly better ifs eric: review+

Tobias Lidskog
Reported 2005-08-27 17:59:27 PDT
filters-comptran-01-b and filters-turb-01-f are currently disabled because they crash when running run- webkit-tests --svg
Attachments
add null checks (19.53 KB, patch)
2005-08-27 18:01 PDT, Tobias Lidskog 		eric: review+
DetailsFormatted DiffDiff
sligthly better ifs (19.40 KB, patch)
2005-08-28 02:33 PDT, Tobias Lidskog 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tobias Lidskog
Comment 1 2005-08-27 18:01:04 PDT
Created attachment 3612 [details] add null checks add null checks to allow tests to run. Also add the related test files. Note that the svg-disabled files should be removed from cvs when this is landed, but I could get the change to be included in the diff
Tobias Lidskog
Comment 2 2005-08-27 19:55:32 PDT
(In reply to comment #1) > ...but I could get the change to be included in the diff should of course be ... I could *not* get the change to be included in the diff
Eric Seidel (no email)
Comment 3 2005-08-28 00:55:29 PDT
Comment on attachment 3612 [details] add null checks These look fine. Thanks!
Tobias Lidskog
Comment 4 2005-08-28 02:33:23 PDT
Created attachment 3620 [details] sligthly better ifs
Eric Seidel (no email)
Comment 5 2005-08-28 03:02:39 PDT
Comment on attachment 3620 [details] sligthly better ifs Looks good.
Note You need to log in before you can comment on or make changes to this bug.