Bug 46993

Summary:

Spatial Navigation: Add support for <input type="radio">

Product:

WebKit

Reporter:

Yael <yael>

Component:

Accessibility

Assignee:

Yael <yael>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ademar, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

46905

Attachments:

Description	Flags
Patch	none
Patch	none

Description Yael 2010-10-01 10:11:27 PDT

We need a way to navigate radio buttons with Spatial Navigation without changing the selection.
Currently, the selection changes when the user navigates to the next radio button within a group.

Comment 1 Yael 2010-10-01 10:59:19 PDT

Created attachment 69488 [details]
Patch

When using Spatial Navigation, every radio button should be focusable and users should be able to navigate from one button to the next without moving the selection.
No tests in this patch yet, I wanted to get initial review while preparing the tests.
thanks!

Comment 2 Yael 2010-10-01 11:50:16 PDT

Comment on attachment 69488 [details]
Patch

I'll be adding tests shortly, cancelling the review.

Comment 3 Yael 2010-10-01 12:36:35 PDT

Created attachment 69504 [details]
Patch

When using Spatial Navigation, every radio button should be focusable and users should be able to navigate from one button to the next without moving the selection.

The patch is the same as before, with the addition of the tests.

Comment 4 WebKit Commit Bot 2010-10-04 22:44:07 PDT

Comment on attachment 69504 [details]
Patch

Clearing flags on attachment: 69504

Committed r69078: <http://trac.webkit.org/changeset/69078>

Comment 5 WebKit Commit Bot 2010-10-04 22:44:12 PDT

All reviewed patches have been landed.  Closing bug.

Comment 6 Ademar Reis 2010-10-05 09:17:52 PDT

Revision r69078 cherry-picked into qtwebkit-2.1 with commit 867aa08 <http://gitorious.org/webkit/qtwebkit/commit/867aa08>