Summary: | Specify ALWAYS_INLINE at function declaration not function definition | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pratik Solanki <psolanki> | ||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, ggaren, psolanki, webkit.review.bot | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Pratik Solanki
2010-09-30 22:48:34 PDT
Created attachment 69426 [details]
Patch
From other files, I see that the practice seems to be to add ALWAYS_INLINE to both definition and declaration so thats what I've done in my patch. Attachment 69426 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
JavaScriptCore/wtf/FastMalloc.cpp:2188: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
JavaScriptCore/wtf/FastMalloc.cpp:2191: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
JavaScriptCore/wtf/FastMalloc.cpp:2292: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
JavaScriptCore/wtf/FastMalloc.cpp:2297: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
JavaScriptCore/wtf/FastMalloc.cpp:2310: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 5 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 69426 [details] Patch Consider these docs: http://gcc.gnu.org/onlinedocs/gcc/Inline.html http://gcc.gnu.org/onlinedocs/gcc-4.0.4/gcc/Attribute-Syntax.html#Attribute-Syntax http://gcc.gnu.org/onlinedocs/gcc-4.0.4/gcc/Function-Attributes.html I'm pretty sure that ALWAYS_INLINE is only needed at the declaration site, not the definition site. Even so, this patch is good, so r=me. Comment on attachment 69426 [details] Patch Clearing flags on attachment: 69426 Committed r68899: <http://trac.webkit.org/changeset/68899> All reviewed patches have been landed. Closing bug. |