Bug 46960 – Specify ALWAYS_INLINE at function declaration not function definition

• Component: New Bugs
• Status: RESOLVED FIXED

[Pratik Solanki]

Take for example the following code in FastMalloc.cpp


template <bool crashOnFailure>
void* malloc(size_t);

void* fastMalloc(size_t size)
{
    return malloc<true>(size);
}


template <bool crashOnFailure>
ALWAYS_INLINE
void* malloc(size_t size) {
...
}

We need to have the ALWAYS_INLINE be on the declaration, otherwise the compiler may not inline the call to malloc<true>(size) in fastMalloc(). There are other instances of this in the code as well. Patch coming up.

[Pratik Solanki]

<rdar://problem/8498709>

[Pratik Solanki]

Created attachment 69426 [details]
Patch

[Pratik Solanki]

From other files, I see that the practice seems to be to add ALWAYS_INLINE to both definition and declaration so thats what I've done in my patch.

[WebKit Review Bot]

Attachment 69426 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
JavaScriptCore/wtf/FastMalloc.cpp:2188:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
JavaScriptCore/wtf/FastMalloc.cpp:2191:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
JavaScriptCore/wtf/FastMalloc.cpp:2292:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
JavaScriptCore/wtf/FastMalloc.cpp:2297:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
JavaScriptCore/wtf/FastMalloc.cpp:2310:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 5 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Geoffrey Garen]

Comment on attachment 69426 [details]
Patch

Consider these docs:

http://gcc.gnu.org/onlinedocs/gcc/Inline.html
http://gcc.gnu.org/onlinedocs/gcc-4.0.4/gcc/Attribute-Syntax.html#Attribute-Syntax
http://gcc.gnu.org/onlinedocs/gcc-4.0.4/gcc/Function-Attributes.html

I'm pretty sure that ALWAYS_INLINE is only needed at the declaration site, not the definition site.

Even so, this patch is good, so r=me.

[WebKit Commit Bot]

Comment on attachment 69426 [details]
Patch

Clearing flags on attachment: 69426

Committed r68899: <http://trac.webkit.org/changeset/68899>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.