Bug 46942
Summary: | [GTK] websocket/tests/bad-sub-protocol-control-chars.html fails on 32-bit Debug bot | ||
---|---|---|---|
Product: | WebKit | Reporter: | Martin Robinson <mrobinson> |
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | abarth, eric, joenotcharles, svillar, webkit.review.bot, zan |
Priority: | P3 | Keywords: | Gtk |
Version: | 528+ (Nightly build) | ||
Hardware: | PC | ||
OS: | Linux |
Martin Robinson
Diff:
--- /home/slave/webkitgtk/gtk-linux-32-debug/build/layout-test-results/websocket/tests/bad-sub-protocol-control-chars-expected.txt 2010-09-30 15:41:50.495479384 -0700
+++ /home/slave/webkitgtk/gtk-linux-32-debug/build/layout-test-results/websocket/tests/bad-sub-protocol-control-chars-actual.txt 2010-09-30 15:41:50.495479384 -0700
@@ -1,5 +1,7 @@
CONSOLE MESSAGE: line 0: Wrong protocol for WebSocket '\u0000'
CONSOLE MESSAGE: line 0: Wrong protocol for WebSocket '\u0009'
+CONSOLE MESSAGE: line 0: Wrong protocol for WebSocket '\u000A'
+CONSOLE MESSAGE: line 0: Wrong protocol for WebSocket '\u000D'
CONSOLE MESSAGE: line 0: Wrong protocol for WebSocket '\u001B'
Test WebSocket bad sub-protocol names by control characters.
@@ -8,9 +10,9 @@
PASS new WebSocket("ws://127.0.0.1:8880/simple", "\0") threw exception Error: SYNTAX_ERR: DOM Exception 12.
PASS new WebSocket("ws://127.0.0.1:8880/simple", " ") threw exception Error: SYNTAX_ERR: DOM Exception 12.
PASS new WebSocket("ws://127.0.0.1:8880/simple", "
-") threw exception SyntaxError: Parse error.
+") threw exception Error: SYNTAX_ERR: DOM Exception 12.
PASS new WebSocket("ws://127.0.0.1:8880/simple", "
-") threw exception SyntaxError: Parse error.
+") threw exception Error: SYNTAX_ERR: DOM Exception 12.
PASS new WebSocket("ws://127.0.0.1:8880/simple", "") threw exception Error: SYNTAX_ERR: DOM Exception 12.
PASS successfullyParsed is true
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Sergio Villar Senin
Works for me both locally and on bots Martin
Sergio Villar Senin
Committed r83303: <http://trac.webkit.org/changeset/83303>
WebKit Review Bot
http://trac.webkit.org/changeset/83303 might have broken Leopard Intel Release (Tests)
The following tests are not passing:
editing/selection/5354455-1.html
editing/selection/5354455-2.html
editing/selection/button-right-click.html
editing/selection/context-menu-on-text.html
editing/selection/context-menu-text-selection.html
editing/selection/empty-cell-right-click.html
editing/spelling/context-menu-suggestions.html
fast/events/context-no-deselect.html
fast/events/context-onmousedown-event.html
fast/events/contextmenu-scrolled-page-with-frame.html
fast/events/right-click-focus.html
media/controls-right-click-on-timebar.html
svg/custom/use-events-crash.svg
Zan Dobersek
The test is now passing consistently on all platforms. Closing the bug.
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&showAllRuns=true&tests=websocket%2Ftests%2Fhybi%2Fbad-sub-protocol-control-chars.html