Bug 46931

Summary: ContextShadow should not call ceil() on m_blurRadius (an integer)
Product: WebKit Reporter: Jarred Nicholls <jarred>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Major CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Proposed patch none

Description Jarred Nicholls 2010-09-30 13:21:44 PDT 
ContextShadow.cpp, lines 157 and 170, call ceil(m_blurRadius) which is passed into IntRect::inflate(int).  This is not only unnecessary (because m_blurRadius is an integer) but it causes a build error with MSVC9+ (haven't tested <MSVC9) about ambiguous call to ceil() which cannot take an integer parameter.
Comment 1 Jarred Nicholls 2010-09-30 13:51:58 PDT 
Created attachment 69376 [details]
Proposed patch
Comment 2 WebKit Commit Bot 2010-09-30 14:20:49 PDT 
Comment on attachment 69376 [details]
Proposed patch

Clearing flags on attachment: 69376

Committed r68824: <http://trac.webkit.org/changeset/68824>
Comment 3 WebKit Commit Bot 2010-09-30 14:20:53 PDT 
All reviewed patches have been landed.  Closing bug.