Bug 46928

Summary: Add isLeftToRightDirection() to RenderStyle
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: CSSAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch bdakin: review+

Dave Hyatt
Reported 2010-09-30 12:29:01 PDT
Add isLeftToRightDirection() to RenderStyle and change callers that did direction() == LTR and direction() == RTL to use this instead.
Attachments
Patch (80.26 KB, patch)
2010-09-30 12:30 PDT, Dave Hyatt 		bdakin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2010-09-30 12:30:20 PDT
Created attachment 69362 [details] Patch
WebKit Review Bot
Comment 2 2010-09-30 12:34:35 PDT
Attachment 69362 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/rendering/RenderFlexibleBox.cpp:578: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Total errors found: 1 in 36 files If any of these errors are false positives, please file a bug against check-webkit-style.
Beth Dakin
Comment 3 2010-09-30 12:56:45 PDT
Comment on attachment 69362 [details] Patch Bonus points if you find the style errors and fix them! But I won't require it since this is basically a search-and-replace patch. Yay.
Dave Hyatt
Comment 4 2010-09-30 13:01:47 PDT
Fixed in r68817..
Eric Seidel (no email)
Comment 5 2010-09-30 13:45:09 PDT
This borked SL.
Eric Seidel (no email)
Comment 6 2010-09-30 13:45:14 PDT
fast/blockflow/root-lr-basic.html -> failed
Note You need to log in before you can comment on or make changes to this bug.