Bug 46920

Summary: [Qt] New buttons style for Qt Mobile theme
Product: WebKit Reporter: Ragner Magalhaes <ragner.magalhaes>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ademar, diegohcg, kenneth, kling, luiz, tonikitoo
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Bug Depends on:    
Bug Blocks: 46349, 46984    
Attachments:
Description Flags
Patch 01
kenneth: review+
Patch screenshot none

Ragner Magalhaes
Reported 2010-09-30 10:34:20 PDT
Adjust new style for buttons, checks, radios and combos.
Attachments
Patch 01 (14.56 KB, patch)
2010-09-30 12:59 PDT, Ragner Magalhaes 		kenneth: review+
DetailsFormatted DiffDiff
Patch screenshot (84.89 KB, image/png)
2010-09-30 13:01 PDT, Ragner Magalhaes 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Ragner Magalhaes
Comment 1 2010-09-30 12:59:07 PDT
Created attachment 69367 [details] Patch 01
Ragner Magalhaes
Comment 2 2010-09-30 13:01:00 PDT
Created attachment 69369 [details] Patch screenshot
Kenneth Rohde Christiansen
Comment 3 2010-09-30 13:34:03 PDT
Comment on attachment 69367 [details] Patch 01 Wow nice :-) I discussed it a bit with Luiz and he will forward you some of our comments.
Luiz Agostini
Comment 4 2010-09-30 13:39:04 PDT
Are the gradients been kept in cache? I think that check backgrounds should be kept in cache and it seems to me that they are not.
Kenneth Rohde Christiansen
Comment 5 2010-09-30 15:46:10 PDT
Kling, maybe you could profile and optimize this theme? especially since it will be the fallback on mobile when the html forms are not styled.
Andreas Kling
Comment 6 2010-09-30 15:47:18 PDT
(In reply to comment #5) > Kling, maybe you could profile and optimize this theme? especially since it will be the fallback on mobile when the html forms are not styled. Will do.
Andreas Kling
Comment 7 2010-10-01 06:52:55 PDT
Committed r68889: <http://trac.webkit.org/changeset/68889>
Ademar Reis
Comment 8 2010-10-06 07:05:52 PDT
Revision r68889 cherry-picked into qtwebkit-2.1 with commit fb11250 <http://gitorious.org/webkit/qtwebkit/commit/fb11250>
Note You need to log in before you can comment on or make changes to this bug.