Bug 46889

Summary: xml:space attribute is not mapped to its corresponding CSS property for all SVG*Elements except SVGTextContentElement
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: SVGAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED INVALID    
Severity: Normal CC: krit, mdelaney7, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 45532    
Attachments:
Description Flags
Patch none

Nikolas Zimmermann
Reported 2010-09-30 05:17:29 PDT
The bug is not visible right now, but without this patch the new text layout engine won't work properly. xml:lang="preserve" is not propagated across elements. Eg <g xml:space="preserve"><text...> doesn't affect the <text> element in the new layout engine.
Attachments
Patch (21.12 KB, patch)
2010-09-30 05:26 PDT, Nikolas Zimmermann
no flags
Nikolas Zimmermann
Comment 1 2010-09-30 05:19:26 PDT
s/xml:lang/xml:space/ oops!
Nikolas Zimmermann
Comment 2 2010-09-30 05:26:12 PDT
Dirk Schulze
Comment 3 2010-09-30 05:28:19 PDT
Why can't it get covered by a test right now?
Nikolas Zimmermann
Comment 4 2010-09-30 05:34:43 PDT
(In reply to comment #3) > Why can't it get covered by a test right now? You're right! The bug is probably present already, I need a fresh build with only this patch applied, to see if it changes results. Sorry, didn't think about it earlier.
Dirk Schulze
Comment 5 2010-09-30 05:35:32 PDT
Comment on attachment 69327 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69327&action=review PLeae comment why you can't test it with a new test and fix the style issue. > WebCore/svg/SVGTextPositioningElement.cpp:163 > + if (!node->hasTagName(SVGNames::textTag) > + && !node->hasTagName(SVGNames::tspanTag) > +#if ENABLE(SVG_FONTS) > + && !node->hasTagName(SVGNames::altGlyphTag) > +#endif > + && !node->hasTagName(SVGNames::trefTag)) wrong indention.
Nikolas Zimmermann
Comment 6 2010-09-30 12:11:41 PDT
Comment on attachment 69327 [details] Patch Clearing review flag. Thanks Dirk, the patch is obsolete now!
Note You need to log in before you can comment on or make changes to this bug.