Bug 46866

Summary: webkit-patch failure-reason dies if non-trunk commits are in the blame range
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aroben, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Eric Seidel (no email)
Reported 2010-09-29 18:56:36 PDT
webkit-patch failure-reason dies if non-trunk commits are in the blame range
Attachments
Patch (3.35 KB, patch)
2010-09-29 19:22 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch (6.06 KB, patch)
2010-09-29 19:56 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-09-29 19:22:37 PDT
Created attachment 69295 [details] Patch
Eric Seidel (no email)
Comment 2 2010-09-29 19:56:33 PDT
Created attachment 69301 [details] Patch
Adam Barth
Comment 3 2010-09-29 20:01:20 PDT
Comment on attachment 69301 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69301&action=review > WebKitTools/Scripts/webkitpy/tool/mocktool.py:452 > + # The real Checkout would probably throw an exception, but this is the only way tests have to get None back at the moment. > + if not svn_revision: > + return None ???
WebKit Commit Bot
Comment 4 2010-09-30 02:12:42 PDT
Comment on attachment 69301 [details] Patch Clearing flags on attachment: 69301 Committed r68766: <http://trac.webkit.org/changeset/68766>
WebKit Commit Bot
Comment 5 2010-09-30 02:12:47 PDT
All reviewed patches have been landed. Closing bug.
Adam Roben (:aroben)
Comment 6 2010-09-30 06:51:56 PDT
*** Bug 40712 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.