Bug 46849

Summary: [chromium] Add accelerated compositing support to DumpRenderTree and test_shell
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: Tools / TestsAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, fishd, jamesr, senorblanco, tkent, vangelis
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 48470    
Attachments:
Description Flags
Patch dglazkov: review+, kbr: commit-queue-

Kenneth Russell
Reported 2010-09-29 16:00:32 PDT
In order to enable automated testing, accelerated compositing support must be added to DumpRenderTree and test_shell. This is the WebKit half of http://crbug.com/51879 .
Attachments
Patch (19.78 KB, patch)
2010-09-29 16:31 PDT, Kenneth Russell 		dglazkov: review+
kbr: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2010-09-29 16:31:06 PDT
Created attachment 69275 [details] Patch From the ChangeLog: Added offscreen code path for WebGraphicsContext3DDefaultImpl which works with the compositor integration in both DumpRenderTree and test_shell, since both pass a non-null WebCanvas* to WebViewImpl::paint and thereby trigger the compositor's readback code path. Added support for --enable-accelerated-compositing to DumpRenderTree. Tested in both test_shell and DumpRenderTree on Linux, the latter by modifying a compositing layout test, dumping the pixels and verifying that they matched the output when the compositor was active.
Vangelis Kokkevis
Comment 2 2010-09-29 17:24:07 PDT
Comment on attachment 69275 [details] Patch Looks good.
Kent Tamura
Comment 3 2010-09-29 18:34:04 PDT
Comment on attachment 69275 [details] Patch The DRT part looks OK.
Dimitri Glazkov (Google)
Comment 4 2010-09-29 21:04:06 PDT
Comment on attachment 69275 [details] Patch ok.
Kenneth Russell
Comment 5 2010-09-30 10:36:48 PDT
Committed r68801: <http://trac.webkit.org/changeset/68801>
Note You need to log in before you can comment on or make changes to this bug.