Bug 46821

Summary: [chromium] enable -Werror on chromium linux webkit
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: jamesr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch jamesr: review+

Tony Chang
Reported 2010-09-29 10:39:13 PDT
[chromium] enable -Werror on chromium linux webkit
Attachments
Patch (2.50 KB, patch)
2010-09-29 10:39 PDT, Tony Chang 		jamesr: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2010-09-29 10:39:52 PDT
Created attachment 69213 [details] Patch
Tony Chang
Comment 2 2010-09-29 10:41:10 PDT
This is going to fail the style checker, but we have to use NULL instead of 0 otherwise gcc complains about "missing sentinel in function call". Tested on hardy -O0, -O1, -O2 and lucid -O0, -O2.
WebKit Review Bot
Comment 3 2010-09-29 10:41:31 PDT
Attachment 69213 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit/chromium/src/gtk/WebInputEventFactory.cpp:55: Use 0 instead of NULL. [readability/null] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
James Robinson
Comment 4 2010-09-29 13:53:32 PDT
Comment on attachment 69213 [details] Patch Code changes look good. Please compile test on hardy before landing.
James Robinson
Comment 5 2010-09-29 13:55:22 PDT
Ah, I see you did. Bombs away!
Tony Chang
Comment 6 2010-09-29 15:06:32 PDT
Committed r68691: <http://trac.webkit.org/changeset/68691>
Note You need to log in before you can comment on or make changes to this bug.