Bug 46774

Summary: Add WKStringIsEqual to the WK2 API
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
beidson: commit-queue-
Better, noncrashy fix sam: review+, beidson: commit-queue-

Brady Eidson
Reported 2010-09-28 18:58:05 PDT
Add WKStringIsEqual to the WK2 API
Attachments
Patch (1.44 KB, patch)
2010-09-28 18:59 PDT, Brady Eidson 		beidson: commit-queue-
DetailsFormatted DiffDiff
Better, noncrashy fix (1.57 KB, patch)
2010-09-30 15:29 PDT, Brady Eidson 		sam: review+
beidson: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2010-09-28 18:59:28 PDT
Created attachment 69151 [details] Patch
chris fleizach
Comment 2 2010-09-30 12:36:12 PDT
Comment on attachment 69151 [details] Patch should you check if one or the other string is nil i would expect WKStringIsEqual("blah", nil) to return false and not crash
Brady Eidson
Comment 3 2010-09-30 15:29:09 PDT
Created attachment 69390 [details] Better, noncrashy fix
Brady Eidson
Comment 4 2010-09-30 15:42:20 PDT
http://trac.webkit.org/changeset/68844
Note You need to log in before you can comment on or make changes to this bug.