Bug 46771 – Rename chromium's GraphicsContext3D.cpp to match others.

• Component: WebGL
• Status: RESOLVED FIXED

[Alexey Marinichev]

There are two of those in the webkit tree:

  WebCore/platform/graphics/GraphicsContext3D.cpp, which implements functions shared by all implementations,

and

  WebKit/chromium/src/GraphicsContext3D.cpp, which implements chromium's version.

It would be more consistent and easier to follow, if the first one was renamed to, say, GraphicsContext3DCommon.cpp, and the second to GraphicsContext3DChromium.cpp.

[Alexey Marinichev]

Created attachment 69148 [details]
Patch

[Kenneth Russell]

Comment on attachment 69148 [details]
Patch

You need to take into consideration that platform/graphics/GraphicsContext3D.cpp is currently compiled in to all platforms. You will minimally need to also modify WebCore/WebCore.xcodeproj/project.pbxproj . I don't know whether you need to strictly make this modification in Xcode or whether you can do it in a text editor. You should also do a recursive grep on all flat files in the WebKit workspace to see where else this file name is referenced. Since the bots apparently can't build on Mac unless you're a WebKit committer I strongly suggest testing your build modifications on Mac OS X -- or your reviewer will need to do so for safety.

[Chris Marrin]

Comment on attachment 69148 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69148&action=review

> WebCore/ChangeLog:10
> +        * platform/graphics/GraphicsContext3DCommon.cpp: Renamed from WebCore/platform/graphics/GraphicsContext3D.cpp.

I'm very much against this renaming. We have many places where we use the current naming convention: GraphicsLayer, GraphicsContext, FloatRect, and virtually every other "common" file in platoform/graphics, as well as other platform specific code throughout the tree. Yes, the Chromium specific version should be renamed, but please do not change the name of the above file

[Alexey Marinichev]

Ouch.  Won't touch WebCore.

[Alexey Marinichev]

Created attachment 69229 [details]
Patch

[Kenneth Russell]

Comment on attachment 69229 [details]
Patch

Looks fine. Assuming you've built this locally to test.

[WebKit Commit Bot]

Comment on attachment 69229 [details]
Patch

Clearing flags on attachment: 69229

Committed r68759: <http://trac.webkit.org/changeset/68759>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.