Bug 46762

Summary:

WebKit.gyp always builds as static_library, breaking shared chromium builds

Product:

WebKit

Reporter:

Matt Mueller <mattm>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dglazkov, fishd, yaar

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
use 'webkit_target_type': '<(library)' when inside_chromium_build	none
Patch	none

Matt Mueller

Reported 2010-09-28 15:59:55 PDT

WebKit gets unconditionally built statically, regardless what the library setting of Chromium build is. Since libwebkit is linked in multiple libraries in chrome, this causes issues with initializers and finalizers getting called multiple times. Building webkit as a shared library fixes this issue. I saw http://trac.webkit.org/changeset/50985 which changed it to be built statically under chromium and shared otherwise, and http://trac.webkit.org/changeset/53001 which caused it to always be built statically. The reasoning isn't entirely clear to me, but it seems that, at least when building under chromium, we should just use the <(library) setting to build webkit. Chromium bugs caused by this: http://code.google.com/p/chromium/issues/detail?id=47575 http://code.google.com/p/chromium/issues/detail?id=47979

Attachments
use 'webkit_target_type': '<(library)' when inside_chromium_build (1.81 KB, patch) 2010-09-28 16:05 PDT, Matt Mueller	no flags	Details Formatted Diff Diff
Patch (1.96 KB, patch) 2010-09-29 15:25 PDT, Matt Mueller	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Matt Mueller

Comment 1 2010-09-28 16:05:48 PDT

Created attachment 69124 [details] use 'webkit_target_type': '<(library)' when inside_chromium_build

WebKit Commit Bot

Comment 2 2010-09-29 12:33:57 PDT

Comment on attachment 69124 [details] use 'webkit_target_type': '<(library)' when inside_chromium_build Rejecting patch 69124 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'apply-attachment', '--force-clean', '--non-interactive', '--quiet', 69124]" exit_code: 2 Cleaning working directory Updating working directory Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=69124&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=46762&ctype=xml Processing 1 patch from 1 bug. Processing patch 69124 from bug 46762. Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Darin Fisher', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/4225010

Matt Mueller

Comment 3 2010-09-29 15:25:14 PDT

Created attachment 69259 [details] Patch

Matt Mueller

Comment 4 2010-09-29 15:28:29 PDT

I think that failed because the patch didn't have full paths, since I just generated it from a regular chromium checkout. Generated a new patch using a full webkit checkout, hopefully this one will work correctly.

Matt Mueller

Comment 5 2010-10-04 13:51:43 PDT

ping, mind taking another quick look?

WebKit Commit Bot

Comment 6 2010-10-04 21:21:54 PDT

Comment on attachment 69259 [details] Patch Clearing flags on attachment: 69259 Committed r69067: <http://trac.webkit.org/changeset/69067>

WebKit Commit Bot

Comment 7 2010-10-04 21:22:01 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.