Summary: | WebKit.gyp always builds as static_library, breaking shared chromium builds | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Matt Mueller <mattm> | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, dglazkov, fishd, yaar | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Attachments: |
|
Description
Matt Mueller
2010-09-28 15:59:55 PDT
Created attachment 69124 [details]
use 'webkit_target_type': '<(library)' when inside_chromium_build
Comment on attachment 69124 [details] use 'webkit_target_type': '<(library)' when inside_chromium_build Rejecting patch 69124 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'apply-attachment', '--force-clean', '--non-interactive', '--quiet', 69124]" exit_code: 2 Cleaning working directory Updating working directory Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=69124&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=46762&ctype=xml Processing 1 patch from 1 bug. Processing patch 69124 from bug 46762. Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Darin Fisher', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/4225010 Created attachment 69259 [details]
Patch
I think that failed because the patch didn't have full paths, since I just generated it from a regular chromium checkout. Generated a new patch using a full webkit checkout, hopefully this one will work correctly. ping, mind taking another quick look? Comment on attachment 69259 [details] Patch Clearing flags on attachment: 69259 Committed r69067: <http://trac.webkit.org/changeset/69067> All reviewed patches have been landed. Closing bug. |