Bug 46748

Summary: [Qt] QWebElements example from QtWebKit Bridge documentation does not work at all
Product: WebKit Reporter: Torsten Werner <twerner>
Component: WebKit QtAssignee: Noam Rosenthal <noam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, noam
Priority: P4 Keywords: EasyFix, Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
source code to reproduce the bug
none
Patch none

Torsten Werner
Reported 2010-09-28 13:11:40 PDT
I've already submitted the bug at <http://bugreports.qt.nokia.com/browse/QTBUG-13977> but it got closed without a solution. The documentation at http://doc.qt.nokia.com/4.7/qtwebkit-bridge.html tells us: "A signal, slot or property that expects or returns a QWebElement can work seamlessly with JavaScript references to DOM elements." But that does not work in my code. I am attaching a tar file with some minimal example code to reproduce the problem with QT 4.7. This code shows that * the JavaScript function works() can call a slot doSomethingWithString with a QString as an argument, but * the JavaScript function fails() just throws an exception when calling a slot doSomethingWithWebElement with a QWebElement as an argument. The actual JavaScript exception is: TypeError: cannot call doSomethingWithWebElement(): unknown type `QWebElement'
Attachments
source code to reproduce the bug (3.70 KB, application/gzip)
2010-09-28 13:12 PDT, Torsten Werner 		no flags
Details
Patch (4.24 KB, patch)
2011-01-30 19:26 PST, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Torsten Werner
Comment 1 2010-09-28 13:12:54 PDT
Created attachment 69092 [details] source code to reproduce the bug
Noam Rosenthal
Comment 2 2011-01-30 17:23:01 PST
Oops, had a bug about this already and I completely missed it. *** This bug has been marked as a duplicate of bug 37319 ***
Noam Rosenthal
Comment 3 2011-01-30 18:06:04 PST
Reopening, fix for the duplicate bug didn't fix this one :(
Noam Rosenthal
Comment 4 2011-01-30 19:26:34 PST
Created attachment 80613 [details] Patch
WebKit Commit Bot
Comment 5 2011-01-31 20:33:39 PST
The commit-queue encountered the following flaky tests while processing attachment 80613 [details]: http/tests/xmlhttprequest/cross-origin-no-authorization.html bug 33357 (author: ap@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2011-01-31 20:34:55 PST
Comment on attachment 80613 [details] Patch Clearing flags on attachment: 80613 Committed r77212: <http://trac.webkit.org/changeset/77212>
WebKit Commit Bot
Comment 7 2011-01-31 20:35:00 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.