Summary: | Add PluginControllerProxy class | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||
Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, eric, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Anders Carlsson
2010-09-28 08:51:26 PDT
Created attachment 69059 [details]
Patch
Attachment 69059 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/PluginProcess/PluginControllerProxy.cpp:28: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Total errors found: 1 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 69059 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69059&action=review > WebKit2/ChangeLog:17 > + (WebKit::WebProcessConnection::addPluginControllerProxy > + Add the plug-in controller proxy to the map. Missing the trailing ): here. > WebKit2/PluginProcess/PluginControllerProxy.h:65 > + // We use a weak reference to the web process connection because the WebProcessConnection has a strong > + // reference to the PluginControllerProxy objects. > + WebProcessConnection* m_connection; Since PluginControllerProxy is ref-counted, it's hard to guarantee that it doesn't outlive its WebProcessConnection. Maybe we should have a way to tell PluginControllerProxy that its WebProcessConnection has been destroyed. > WebKit2/PluginProcess/WebProcessConnection.cpp:52 > +void WebProcessConnection::addPluginControllerProxy(PluginControllerProxy* pluginController) This should take a PassRefPtr. Committed r68522: <http://trac.webkit.org/changeset/68522> http://trac.webkit.org/changeset/68522 might have broken GTK Linux 64-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/68521 http://trac.webkit.org/changeset/68522 |