Bug 46715

Summary:

plugins/npruntime/invoke-failure.html fails in WebKit2 due to slightly different exception being thrown

Product:

WebKit

Reporter:

Adam Roben (:aroben) <aroben>

Component:

Plug-ins

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, jhoneycutt

Priority:

Keywords:

InRadar, LayoutTestFailure

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Adam Roben (:aroben) 2010-09-28 04:16:19 PDT

plugins/npruntime/invoke-failure.html fails in WebKit2 due to a slightly different exception being thrown. Here's the diff:

--- /tmp/layout-test-results/plugins/npruntime/invoke-failure-expected.txt	2010-09-27 19:41:55.453000000 -0400
+++ /tmp/layout-test-results/plugins/npruntime/invoke-failure-actual.txt	2010-09-27 19:41:55.453000000 -0400
@@ -1,2 +1,2 @@
 
-SUCCESS: Exception caught: Error: Error calling method on NPObject!
+SUCCESS: Exception caught: Error: Error calling method on NPObject.

Comment 1 Adam Roben (:aroben) 2010-09-28 04:30:39 PDT

<rdar://problem/8485909>

Comment 2 Anders Carlsson 2010-09-29 16:14:49 PDT

Created attachment 69270 [details]
Patch

Comment 3 Darin Adler 2010-09-29 16:17:53 PDT

Comment on attachment 69270 [details]
Patch

Those exclamation points are horrible!

Comment 4 Anders Carlsson 2010-09-29 16:47:49 PDT

I talked to Darin and we agreed to get rid of the exclamation points everywhere instead.

Comment 5 Anders Carlsson 2010-09-29 16:48:01 PDT

Comment on attachment 69270 [details]
Patch

Clearing review flag.

Comment 6 Anders Carlsson 2010-09-29 16:52:50 PDT

Committed r68716: <http://trac.webkit.org/changeset/68716>