Summary: | Document::nodesFromRect should not consider zoom factor. | ||
---|---|---|---|
Product: | WebKit | Reporter: | Antonio Gomes <tonikitoo> |
Component: | DOM | Assignee: | Antonio Gomes <tonikitoo> |
Status: | RESOLVED INVALID | ||
Severity: | Normal | CC: | aroben, benjamin, fsamuel, kenneth |
Priority: | P2 | Keywords: | Qt |
Version: | 528+ (Nightly build) | ||
Hardware: | PC | ||
OS: | OS X 10.5 | ||
Bug Depends on: | |||
Bug Blocks: | 68075 |
Description
Antonio Gomes
2010-09-27 21:48:35 PDT
What about scale? Like we scale the QPainter when "zooming" using our tiling implementation. (In reply to comment #1) > What about scale? Like we scale the QPainter when "zooming" using our tiling implementation. That is a very good point. This scaling also affect the way Qt implement https://bugs.webkit.org/show_bug.cgi?id=44088. (In reply to comment #2) > (In reply to comment #1) > > What about scale? Like we scale the QPainter when "zooming" using our tiling implementation. > > That is a very good point. > This scaling also affect the way Qt implement https://bugs.webkit.org/show_bug.cgi?id=44088. so when Qt scales the tiled backing store, it does not call webkit's zoom factor? I will think and test and let you know. (In reply to comment #3) > (In reply to comment #2) > > (In reply to comment #1) > > > What about scale? Like we scale the QPainter when "zooming" using our tiling implementation. > > > > That is a very good point. > > This scaling also affect the way Qt implement https://bugs.webkit.org/show_bug.cgi?id=44088. > > so when Qt scales the tiled backing store, it does not call webkit's zoom factor? > > I will think and test and let you know. It does not. There is a difference between scale and zoom. For instance when zooming (let's forget about text-only zoom for now) you do not scale the native-rendered html forms, though we "try" to adjust their sizes which is not always possible. Scaling, scales everything and this is what you see on mobile devices, even the viewport meta tag uses values such as "initial-scale" :-) and not "initial-zoom..." Well, I have not check the source yet, but for scaling it should work in the same way as it does currently for clicking with it is scaled: the click point has to be translated to something webcore understands, anyways. In fact, the bug is the other way around. WebCore's page zoom _has_ to be considered when calling Document::nodesFromRect. The padding values have to be inversely proportional to the current webcore zoom factor. Same with scaling: but in the scaling case, probably the easier is the caller site to actually pass the padding values adjusted according to the current scale. |