| Summary: | [chromium] Increase warning level for chromium linux build | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | James Robinson <jamesr> | ||||||
| Component: | New Bugs | Assignee: | James Robinson <jamesr> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | agl, dglazkov, fishd, thakis, tony | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Other | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
|
Description
James Robinson
2010-09-27 19:00:53 PDT
Created attachment 69009 [details]
Patch
Comment on attachment 69009 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69009&action=review > WebCore/WebCore.gyp/WebCore.gyp:247 > # enable -Wall and -Werror, just in Mac build for now update this comment? > WebCore/platform/chromium/ScrollbarThemeChromiumLinux.cpp:118 > + || ((direction == PlatformThemeChromiumGtk::East || direction == PlatformThemeChromiumGtk::South) && scrollbar->currentPos() != scrollbar->maximum())) This looks overparenthesized. What's the warning without this? LGTM, although I also wonder about the additional ( ) (In reply to comment #2) > (From update of attachment 69009 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=69009&action=review > > > WebCore/WebCore.gyp/WebCore.gyp:247 > > # enable -Wall and -Werror, just in Mac build for now > > update this comment? > > > WebCore/platform/chromium/ScrollbarThemeChromiumLinux.cpp:118 > > + || ((direction == PlatformThemeChromiumGtk::East || direction == PlatformThemeChromiumGtk::South) && scrollbar->currentPos() != scrollbar->maximum())) > > This looks overparenthesized. What's the warning without this? There's an a || b && c in there which makes the second pair of () that james added necessary. I think we can drop the first pair of (). Comment on attachment 69009 [details]
Patch
r=me with review comments addressed
gcc requires "a || b && c" have parens around the "b && c" part. The rest of the parens on that line are needed, I believe the rest of the parens are still needed. However I forgot to check in debug as well. Will update. Comment on attachment 69009 [details]
Patch
Missed some.
Created attachment 69106 [details]
Patch
Fixed the comment in the .gyp and drops one set of parens from ScrollbarThemeChromiumLinux.cpp. Committed r68564: <http://trac.webkit.org/changeset/68564> |