Bug 46683

Summary:

Remove obsolete registerExtension variants from chromium port

Product:

WebKit

Reporter:

Matt Perry <mpcomplete>

Component:

WebCore JavaScript

Assignee:

Matt Perry <mpcomplete>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, fishd, levin

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
remove obsolete methods	none

Matt Perry

Reported 2010-09-27 18:08:23 PDT

This is part2 of this bug: https://bugs.webkit.org/show_bug.cgi?id=45721 Now that the Chromium side of this change is checked in, the old versions of these functions can be removed.

Attachments
remove obsolete methods (9.00 KB, patch) 2010-09-27 18:14 PDT, Matt Perry	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Matt Perry

Comment 1 2010-09-27 18:14:37 PDT

Created attachment 69006 [details] remove obsolete methods

David Levin

Comment 2 2010-09-27 18:43:26 PDT

(knee jerk question) Why is there no DEPS roll (webKit/chromium/DEPS) with this to pick up the chromium side change?

Matt Perry

Comment 3 2010-09-28 14:55:42 PDT

(In reply to comment #2) > (knee jerk question) Why is there no DEPS roll (webKit/chromium/DEPS) with this to pick up the chromium side change? Thanks for pointing that out - I didn't know that WebKit/chromium had a DEPS file! It looks like DEPS has already been updated since I landed the chromium side though. (Chromium side is http://src.chromium.org/viewvc/chrome?view=rev&revision=60350 , DEPS points to r60394.)

WebKit Commit Bot

Comment 4 2010-09-29 11:01:35 PDT

Comment on attachment 69006 [details] remove obsolete methods Clearing flags on attachment: 69006 Committed r68666: <http://trac.webkit.org/changeset/68666>

WebKit Commit Bot

Comment 5 2010-09-29 11:01:45 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.