Summary: | Add WebProcessConnection CreatePlugin message | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||
Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Anders Carlsson
2010-09-27 15:53:55 PDT
Created attachment 68983 [details]
Patch
Comment on attachment 68983 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68983&action=review > WebKit2/PluginProcess/WebProcessConnection.messages.in:26 > + # Creates a plug-in instance with the given instance ID. I think // comments will work just fine, if that's what you'd prefer. > WebKit2/Scripts/webkit2/messages.py:219 > +def headers_for_type(type): > + special_cases = { > + 'WTF::String': '<wtf/text/WTFString.h>', > + 'WebKit::WebKeyboardEvent': '"WebEvent.h"', > + 'WebKit::WebMouseEvent': '"WebEvent.h"', > + 'WebKit::WebWheelEvent': '"WebEvent.h"', > + 'WebKit::WebTouchEvent': '"WebEvent.h"', > + } > + if type in special_cases: > + return [special_cases[type]] > + > + # We assume that we must include a header for a type iff it has a scope > + # resolution operator (::). > + split = type.split('::') > + if len(split) < 2: > + return [] > + if split[0] == 'WebKit' or split[0] == 'CoreIPC': > + return ['"%s.h"' % split[1]] > + return ['<%s/%s.h>' % tuple(split)] Why did you move this? Committed r68445: <http://trac.webkit.org/changeset/68445> |