Bug 46663

Summary:

FrameLoaderClient::didTransferChildFrameToNewDocument needs access to old page

Product:

WebKit

Reporter:

Jenn Braithwaite <jennb>

Component:

Frames

Assignee:

Jenn Braithwaite <jennb>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, commit-queue, dimich

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

44713

Attachments:

Description	Flags
patch	none
rollback api change	dimich: review-, dimich: commit-queue-
updated patch	abarth: review+, abarth: commit-queue+

Jenn Braithwaite

Reported 2010-09-27 15:23:52 PDT

Mac client needs access to the reparented frame's former page in order to update resource tracking (see bug 44713).

Attachments
patch (26.49 KB, patch) 2010-09-27 17:25 PDT, Jenn Braithwaite	no flags	Details Formatted Diff Diff
rollback api change (26.83 KB, patch) 2010-10-28 15:28 PDT, Jenn Braithwaite	dimich: review- dimich: commit-queue-	Details Formatted Diff Diff
updated patch (26.97 KB, patch) 2010-10-28 16:32 PDT, Jenn Braithwaite	abarth: review+ abarth: commit-queue+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Jenn Braithwaite

Comment 1 2010-09-27 17:25:41 PDT

Created attachment 68996 [details] patch

Jenn Braithwaite

Comment 2 2010-09-28 11:53:09 PDT

This patch merely adds a parameter to FrameLoaderClient::didTransferChildFrameToNewDocument(). Code to use it will be in a separate patch - probably the one that fixes bug 44713.

WebKit Commit Bot

Comment 3 2010-09-28 15:27:40 PDT

Comment on attachment 68996 [details] patch Clearing flags on attachment: 68996 Committed r68576: <http://trac.webkit.org/changeset/68576>

WebKit Commit Bot

Comment 4 2010-09-28 15:27:45 PDT

All reviewed patches have been landed. Closing bug.

Jenn Braithwaite

Comment 5 2010-10-14 11:18:32 PDT

Turns out I don't need this API change after all because the update resource tracking trigger needs to go in WebCore and not the WebKit client layer. What's the best way to revert this patch? Or is it too late for a simple revert and I am better off entering a new bug and submitting a new patch to undo this change?

Dmitry Titov

Comment 6 2010-10-14 12:08:07 PDT

(In reply to comment #5) Simple revert (with ChangeLog reflecting both changes) is just fine. No need for new bug.

Jenn Braithwaite

Comment 7 2010-10-28 15:28:34 PDT

Created attachment 72245 [details] rollback api change

Dmitry Titov

Comment 8 2010-10-28 15:44:04 PDT

Comment on attachment 72245 [details] rollback api change View in context: https://bugs.webkit.org/attachment.cgi?id=72245&action=review Small ChangeLog nit. r- since it's going via cq, so needs to be changed first. > WebCore/ChangeLog:5 > + Rollback: Could you add revisions, as in: Rollback of <url to rev in trac>: Also, since you edit it manually, lets add a reason for rollback (design changed, no need for parameter). > WebKit/chromium/ChangeLog:5 > + Rollback: Ditto here (rev number and reason, also for all ChangeLogs)

Jenn Braithwaite

Comment 9 2010-10-28 16:32:41 PDT

Created attachment 72256 [details] updated patch Added revision info and link along with description to ChangeLogs. Put back a few extra lines of code that are still needed: oldPage local var in Frame.cpp, plus include and class declarations for Page. Page is now used elsewhere in the file, so it's not safe to rollback those lines.

Adam Barth

Comment 10 2010-10-31 18:06:58 PDT

Comment on attachment 72256 [details] updated patch So many files.

Note You need to log in before you can comment on or make changes to this bug.