Bug 46638
| Summary: | Build: removal of public WebCore headers not handled properly during incremental build | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Andrey Kosyakov <caseq> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | aroben, bweinstein, eric |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
Andrey Kosyakov
The build script copies public WebCore header files to WebKitBuild/include. Apparently, when a header is removed from source tree, it is not reflected in WebKitBuild/include during an incremental build. Hence, if there's still a file in WebKit that depends on the removed header, the compilation does not fail.
See http://trac.webkit.org/changeset/68384 & http://trac.webkit.org/changeset/68371 for example of this happening (the bots did not indicate a build failure).
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Eric Seidel (no email)
Thank you for filing. There are lots of windows build issues. We need to slowly find them all and fix them all to keep our sanity. :)