Bug 46632 – The last word in each line, encased in a tag with either a background or border value, is cropped.

• Component: Layout and Rendering
• Status: RESOLVED WORKSFORME

[Claus Es]

Created attachment 68930 [details]
border.html + style.css test case for CSS background

The last word in each line, encased in a tag with either a background or border value, is sometimes cropped in all Safari versions.

Firefox renderes the attached case in an expected manner.
Safari 5.0.2, Webkit 5.0.2 (6533.18.5, r68204), Webkit on the iPad iOS 3.1.2, and Webkit on the iPhone 3G iOS 3.1.2 are showing this unexpected rendering.

Created attachment 74041 [details]
Proposed Patch

[Darin Adler]

Comment on attachment 74041 [details]
Proposed Patch

The WebKit project requires test cases to be landed along with bug fixes. This code change looks good, but we need either a test case or an explanation of why we can’t test it.

Created attachment 74275 [details]
Patch

Added a pixel layout test ... LayoutTests/fast/borders/border-rightEdge-bug46632.html. 
The rightEdge of First2 element displays correctly with this fix. 

Modified the patch. Passing the endObject as an argument to 
the method determineSpacingForFlowBoxes directly without testing 
for end.pos.

Created attachment 76779 [details]
Patch

[Darin Adler]

Comment on attachment 76779 [details]
Patch

Test case looks good. I'm not 100% certain the logic here is right because it’s slightly outside my area of expertise, but I’ll say r=me.

[WebKit Commit Bot]

Comment on attachment 76779 [details]
Patch

Rejecting attachment 76779 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'build-and-test', '--no-clean', '--no-update', '--test', '--non-interactive']" exit_code: 2
Last 500 characters of output:
............................................................................................................................................................................................................................................................................
css2.1/t090501-c414-flt-ln-02-d.html -> failed

Exiting early after 1 failures. 1529 tests run.
57.04s total testing time

1528 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
3 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/7235284

Created attachment 77933 [details]
Patch

Created a new base line for test case css2.1/t090501-c414-flt-ln-02-d.html. 
The borders for the small boxes A.B,D are not displayed in full. The right edges 
are cropped. With this fix they would be displayed fully. Updated the png and 
checksum files for mac platform.

[Eric Seidel (no email)]

Comment on attachment 76779 [details]
Patch

Cleared Darin Adler's review+ from obsolete attachment 76779 [details] so that this bug does not appear in http://webkit.org/pending-commit.

[Beth Dakin]

Comment on attachment 77933 [details]
Patch

This patch doesn't apply cleanly anymore. But also, I think the bug has been fixed! The test case looks right in TOT, and the call to constructLine() seems to have a similar fix in place.

[Beth Dakin]

Resolving for now since I believe this is now fixed. Please re-open if it's not.