Bug 46607

Summary:

[WML] Fix a build break when WML is enabled.

Product:

WebKit

Reporter:

Gyuyoung Kim <gyuyoung.kim>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, krit

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
Patch	none

Gyuyoung Kim

Reported 2010-09-26 22:51:59 PDT

There is a build break as below when WML is enabled. ============================================================================================= /home/gyuyoung/webkit/WebKit/WebCore/wml/WMLElement.cpp: In member function ‘virtual void WebCore::WMLElement::parseMappedAttribute(WebCore::Attribute*)’: /home/gyuyoung/webkit/WebKit/WebCore/wml/WMLElement.cpp:76: error: ‘parseHTMLInteger’ was not declared in this scope make[2]: *** [WebCore/CMakeFiles/webcore_efl.dir/wml/WMLElement.cpp.o] Error 1 ============================================================================================= I think this error comes from Bug 21076.However, even though the Bug 21076 made a patch for WML as well as other modules, there is still error when WML is enabled. I make a patch.

Attachments
Patch (1.51 KB, patch) 2010-09-26 22:55 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Gyuyoung Kim

Comment 1 2010-09-26 22:55:42 PDT

Created attachment 68882 [details] Patch

Dirk Schulze

Comment 2 2010-09-26 23:46:56 PDT

Comment on attachment 68882 [details] Patch Please write the explanation into the ChangeLog as well next time. r=me

Gyuyoung Kim

Comment 3 2010-09-26 23:49:08 PDT

(In reply to comment #2) > (From update of attachment 68882 [details]) > Please write the explanation into the ChangeLog as well next time. r=me Oops. I will add explanation to the ChangeLog on next time. Thank you.

WebKit Commit Bot

Comment 4 2010-09-27 01:06:17 PDT

Comment on attachment 68882 [details] Patch Clearing flags on attachment: 68882 Committed r68375: <http://trac.webkit.org/changeset/68375>

WebKit Commit Bot

Comment 5 2010-09-27 01:06:23 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.