Bug 46602 – new-run-webkit-httpd fails if Perl is not installed

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Mihai Parparita]

new-run-webkit-httpd fails if Perl is not installed

[Mihai Parparita]

Created attachment 68869 [details]
Patch

[Mihai Parparita]

Adam, Eric or Ojan, would you mind taking a look? This is preventing Chromium WebKit rolls.

[WebKit Commit Bot]

Comment on attachment 68869 [details]
Patch

Clearing flags on attachment: 68869

Committed r68365: <http://trac.webkit.org/changeset/68365>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Tony Chang]

BTW, all the bots should have perl installed (e.g., generating bindings from IDL files is a perl script).  Perhaps we need to fix a #! line or make sure cygwin is setup or something.

[Mihai Parparita]

(In reply to comment #5)
> BTW, all the bots should have perl installed (e.g., generating bindings from IDL files is a perl script).  Perhaps we need to fix a #! line or make sure cygwin is setup or something.

_webkit_build_directory assumes that perl is in the path:

http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/layout_tests/port/base.py?rev=68365#L670

Not sure if that's valid under cygwin.

[Tony Chang]

(In reply to comment #6)
> _webkit_build_directory assumes that perl is in the path:
> 
> http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/layout_tests/port/base.py?rev=68365#L670
> 
> Not sure if that's valid under cygwin.

I think it is valid as long as third_party/cygwin/setup_mount.bat is run.  It looks like there's code in ChromiumWinPort for this.  Maybe that code isn't run when using new-run-webkit-httpd (but is when running NRWT)?