Bug 46600

Summary: [Tests] Unskip not failing tests previously relying on LTC::nodesFromRect implementation
Product: WebKit Reporter: Antonio Gomes <tonikitoo>
Component: Tools / TestsAssignee: Allan Sandfeld Jensen <allan.jensen>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, dglazkov, klobag, shanestephens, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 91205    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from gce-cr-linux-07
none
Patch none

Antonio Gomes
Reported 2010-09-26 18:46:48 PDT
fast/dom/nodesFromRect-based.html was skipped by bug 46492. Needs to implement LayoutTestController::nodesFromRect so unskip. Mac has its implementation from bug 46480.
Attachments
Patch (4.02 KB, patch)
2012-07-12 10:14 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from gce-cr-linux-07 (554.84 KB, application/zip)
2012-07-12 11:01 PDT, WebKit Review Bot 		no flags
Details
Patch (4.08 KB, patch)
2012-07-13 02:34 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antonio Gomes
Comment 1 2012-04-05 12:34:10 PDT
Now it uses the internals interface, and test should pass.
Allan Sandfeld Jensen
Comment 2 2012-07-12 10:14:50 PDT
Created attachment 151985 [details] Patch
WebKit Review Bot
Comment 3 2012-07-12 11:01:46 PDT
Comment on attachment 151985 [details] Patch Attachment 151985 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13209808 New failing tests: media/nodesFromRect-shadowContent.html
WebKit Review Bot
Comment 4 2012-07-12 11:01:50 PDT
Created attachment 152002 [details] Archive of layout-test-results from gce-cr-linux-07 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-07 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Allan Sandfeld Jensen
Comment 5 2012-07-13 02:34:06 PDT
Created attachment 152194 [details] Patch
Ryosuke Niwa
Comment 6 2012-07-13 15:14:18 PDT
Comment on attachment 152194 [details] Patch rs=me.
WebKit Review Bot
Comment 7 2012-07-14 07:09:44 PDT
Comment on attachment 152194 [details] Patch Clearing flags on attachment: 152194 Committed r122668: <http://trac.webkit.org/changeset/122668>
WebKit Review Bot
Comment 8 2012-07-14 07:09:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.