Bug 46600

Summary:

[Tests] Unskip not failing tests previously relying on LTC::nodesFromRect implementation

Product:

WebKit

Reporter:

Antonio Gomes <tonikitoo>

Component:

Tools / Tests

Assignee:

Allan Sandfeld Jensen <allan.jensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

allan.jensen, dglazkov, klobag, shanestephens, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

91205

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from gce-cr-linux-07	none
Patch	none

Description Antonio Gomes 2010-09-26 18:46:48 PDT

fast/dom/nodesFromRect-based.html was skipped by bug 46492.

Needs to implement LayoutTestController::nodesFromRect so unskip. Mac has its implementation from bug 46480.

Comment 1 Antonio Gomes 2012-04-05 12:34:10 PDT

Now it uses the internals interface, and test should pass.

Comment 2 Allan Sandfeld Jensen 2012-07-12 10:14:50 PDT

Created attachment 151985 [details]
Patch

Comment 3 WebKit Review Bot 2012-07-12 11:01:46 PDT

Comment on attachment 151985 [details]
Patch

Attachment 151985 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13209808

New failing tests:
media/nodesFromRect-shadowContent.html

Comment 4 WebKit Review Bot 2012-07-12 11:01:50 PDT

Created attachment 152002 [details]
Archive of layout-test-results from gce-cr-linux-07

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-07  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

Comment 5 Allan Sandfeld Jensen 2012-07-13 02:34:06 PDT

Created attachment 152194 [details]
Patch

Comment 6 Ryosuke Niwa 2012-07-13 15:14:18 PDT

Comment on attachment 152194 [details]
Patch

rs=me.

Comment 7 WebKit Review Bot 2012-07-14 07:09:44 PDT

Comment on attachment 152194 [details]
Patch

Clearing flags on attachment: 152194

Committed r122668: <http://trac.webkit.org/changeset/122668>

Comment 8 WebKit Review Bot 2012-07-14 07:09:58 PDT

All reviewed patches have been landed.  Closing bug.