Bug 46597

Summary: [Chromium] fast/dom/anchor-origin.html failing since r68354
Product: WebKit Reporter: James Kozianski <koz>
Component: DOMAssignee: James Kozianski <koz>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, brettw, commit-queue, dglazkov, noel.gordon
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

James Kozianski
Reported 2010-09-26 18:37:57 PDT
Seems to be failing because of URL parsing differences. Here's a snippet from the diff: http://example.com/foo/bar => http://example.com -HTTP://example.com/foo/bar => http://example.com +http://example.com/foo/bar => http://example.com https://example.com/ttt?ggg => https://example.com ftp://example.com/ttt?ggg => ftp://example.com file:///home/abarth => file:// -data:text/html,%3Cb%3Efoo%3C/b%3E => null +data:text/html,foo => null
Attachments
Patch (2.94 KB, patch)
2010-09-26 21:55 PDT, James Kozianski 		no flags
DetailsFormatted DiffDiff
Patch (1.45 KB, patch)
2010-09-26 22:06 PDT, James Kozianski 		no flags
DetailsFormatted DiffDiff
Patch (2.11 KB, patch)
2010-09-26 22:54 PDT, James Kozianski 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-09-26 18:48:59 PDT
Those results are fine. We just need a Chromium baseline.
James Kozianski
Comment 2 2010-09-26 21:55:56 PDT
Created attachment 68879 [details] Patch
Adam Barth
Comment 3 2010-09-26 22:01:03 PDT
Comment on attachment 68879 [details] Patch These results are all the same. Then can go in platform/chromium, no?
James Kozianski
Comment 4 2010-09-26 22:06:37 PDT
Created attachment 68880 [details] Patch
James Kozianski
Comment 5 2010-09-26 22:08:02 PDT
(In reply to comment #3) > (From update of attachment 68879 [details]) > These results are all the same. Then can go in platform/chromium, no? Yes, you're right. Sorry - I trusted the rebaseline-chromium-webkit-tests script output.
Ojan Vafai
Comment 6 2010-09-26 22:29:34 PDT
Comment on attachment 68880 [details] Patch Removing cq+. James is modifying his patch to remove the line from test_expectations.txt.
James Kozianski
Comment 7 2010-09-26 22:54:59 PDT
Created attachment 68881 [details] Patch
WebKit Commit Bot
Comment 8 2010-09-27 01:25:44 PDT
Comment on attachment 68881 [details] Patch Clearing flags on attachment: 68881 Committed r68376: <http://trac.webkit.org/changeset/68376>
WebKit Commit Bot
Comment 9 2010-09-27 01:25:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.