Bug 46588 – MiniBrowser crashes when opening main menu item

• Component: New Bugs
• Status: VERIFIED FIXED

[Jeff Johnson]

Overview:
MiniBrowser (WebKit/WebKitTools/MiniBrowser) crashes when I try to open a main menu item. This only seems to happen with some menu items. Crash: File, Edit, Help. No crash: Apple, MiniBrowser, View, Window, Debug.

Steps to reproduce:
1) Launch MiniBrowser.
2) Open the "File" menu in the main menu bar.

Build Date & Platform:
Mac OS X 10.6.4, WebKit Debug build from svn r68344, Mac Pro 3.33 GHz 6-core

Additional Information:
Below is the gdb backtrace.

ASSERTION FAILED: mainThreadPthread
(/Users/Shared/source/WebKit/JavaScriptCore/wtf/mac/MainThreadMac.mm:136 bool WTF::isMainThread())
Program received signal:  “EXC_BAD_ACCESS”.
(gdb) bt
#0  0x00000001005f1066 in WTF::isMainThread () at /Users/Shared/source/WebKit/JavaScriptCore/wtf/mac/MainThreadMac.mm:136
#1  0x0000000101787e20 in WTF::StringImpl::createCFString (this=0x1081477d0) at /Users/Shared/source/WebKit/WebCore/platform/text/cf/StringImplCF.cpp:136
#2  0x0000000101788151 in WTF::StringImpl::operator NSString* (this=0x1081477d0) at /Users/Shared/source/WebKit/WebCore/platform/text/mac/StringImplMac.mm:30
#3  0x000000010003806b in WTF::String::operator NSString* (this=0x7fff5fbfdb70) at WTFString.h:281
#4  0x0000000100037799 in WebKit::PageClientImpl::setEditCommandState (this=0x105a1e150, commandName=@0x7fff5fbfdb70, isEnabled=true, newState=0) at /Users/Shared/source/WebKit/WebKit2/UIProcess/API/mac/PageClientImpl.mm:206
#5  0x000000010007e144 in WebKit::WebPageProxy::didReceiveMessage (this=0x105c1b650, connection=0x105a2f3b0, messageID={m_messageID = 524319}, arguments=0x105a4b7b0) at /Users/Shared/source/WebKit/WebKit2/UIProcess/WebPageProxy.cpp:858
#6  0x000000010009b3f2 in WebKit::WebProcessProxy::didReceiveMessage (this=0x105a1edd0, connection=0x105a2f3b0, messageID={m_messageID = 524319}, arguments=0x105a4b7b0) at /Users/Shared/source/WebKit/WebKit2/UIProcess/WebProcessProxy.cpp:355
#7  0x0000000100017883 in CoreIPC::Connection::dispatchMessages (this=0x105a2f3b0) at /Users/Shared/source/WebKit/WebKit2/Platform/CoreIPC/Connection.cpp:278
#8  0x0000000100018aad in MemberFunctionWorkItem0<CoreIPC::Connection>::execute (this=0x105a43330) at WorkItem.h:74
#9  0x000000010004c3ab in RunLoop::performWork (this=0x108115bb0) at /Users/Shared/source/WebKit/WebKit2/Platform/RunLoop.cpp:62
#10 0x000000010004d3ed in RunLoop::performWork (context=0x108115bb0) at /Users/Shared/source/WebKit/WebKit2/Platform/mac/RunLoopMac.mm:32
#11 0x00007fff86ff9e91 in __CFRunLoopDoSources0 ()
#12 0x00007fff86ff8089 in __CFRunLoopRun ()
#13 0x00007fff86ff784f in CFRunLoopRunSpecific ()
#14 0x00007fff810ad91a in RunCurrentEventLoopInMode ()
#15 0x00007fff810ad67d in ReceiveNextEventCommon ()
#16 0x00007fff810f7db8 in IsUserStillTracking ()
#17 0x00007fff810e4a48 in TrackMenuCommon ()
#18 0x00007fff810e0c28 in MenuSelectCore ()
#19 0x00007fff810e0408 in _HandleMenuSelection2 ()
#20 0x00007fff87d72c39 in _NSHandleCarbonMenuEvent ()
#21 0x00007fff87d4674e in _DPSNextEvent ()
#22 0x00007fff87d45bed in -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] ()
#23 0x00007fff87d0b8d3 in -[NSApplication run] ()
#24 0x00007fff87d045f8 in NSApplicationMain ()
#25 0x0000000100001588 in start ()

[Sam Weinig]

Created attachment 68870 [details]
Patch

[Sam Weinig]

Fixed in r68364.

[Jeff Johnson]

Verified as fixed