Bug 46571

Summary:

[jsc] Document the op_strcat opcode

Product:

WebKit

Reporter:

Holger Freyther <zecke>

Component:

New Bugs

Assignee:

Holger Freyther <zecke>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	abarth: review+, abarth: commit-queue-

Holger Freyther

Reported 2010-09-25 11:44:03 PDT

Created attachment 68836 [details] Patch strcat is currentlty lacking a documentation, attempt to document the semantic based on other comments.

Attachments
Patch (1.41 KB, patch) 2010-09-25 11:44 PDT, Holger Freyther	abarth: review+ abarth: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adam Barth

Comment 1 2010-09-26 21:10:56 PDT

Comment on attachment 68836 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68836&action=review > JavaScriptCore/ChangeLog:7 > + Need a short description and bug URL (OOPS!) You're supposed to fill out this part of the ChangeLog. :) > JavaScriptCore/interpreter/Interpreter.cpp:4255 > + consurctor, and puts the result in register dst. consurctor => constructor

Holger Freyther

Comment 2 2010-09-27 02:39:14 PDT

Landed in r68379. Thanks for the review!

Note You need to log in before you can comment on or make changes to this bug.