Bug 46566 – [Qt] Add QWebFrame::addToJavaScriptWindowProperty()

• Component: WebKit Qt
• Status: RESOLVED INVALID

[Robert Hogan]

Add or override properties in the DOM Window object.

This is necessary for clients that want to control the values returned by window.innerHeight, window.name and so on.
Clients will want to do this to defeat some of the attacks outlined in https://bugs.webkit.org/show_bug.cgi?id=41801.

[Robert Hogan]

Created attachment 68823 [details]
Patch

[Robert Hogan]

It would be even nicer if we could 'put' a function or method rather than a value in the window property. However I can't see how this would be possible. So if anyone has suggestions please weigh in!

[Simon Hausmann]

Hmm, why not simply overload addToJavascriptWindowObject? :) The Object suffix in them method name refers to the window object, not to adding an object to the window.

[Simon Hausmann]

In the medium term a move to V8 would make all this obsolete though, because then we can have QScriptEngine* QWebFrame::scriptEngine() and you can do everything you could ever imagine (with JavaScript :)

[Robert Hogan]

Created attachment 69222 [details]
Patch

[Robert Hogan]

(In reply to comment #4)
> In the medium term a move to V8 would make all this obsolete though, because then we can have QScriptEngine* QWebFrame::scriptEngine() and you can do everything you could ever imagine (with JavaScript :)

I've updated it per your previous comment anyway - so ball in your court!

QWebFrame::scriptEngine() sounds great though - can't wait!

Am I missing a trick or is there a way of overriding the DOM Window's object properties with the properties of a QObject? I can't see it - hence the current patch to just set the values.

[Robert Hogan]

Any thoughts on this? Will it be accepted?

[Benjamin Poulain]

I am with Simon on this, I think we should not add more stuff to QWebFrame that are really related to the Script Engine. I think it is better to focus on exposing QtScript.

[Jocelyn Turcotte]

=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.