Bug 46558

Summary:

Implement location.origin and HTMLAnchorElement.origin

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, eric, ian, mjs, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	none
Patch for landing	none

Adam Barth

Reported 2010-09-24 23:59:01 PDT

Implement location.origin and HTMLAnchorElement.origin

Attachments
Patch (7.28 KB, patch) 2010-09-25 00:04 PDT, Adam Barth	no flags	Details Formatted Diff Diff
Patch (7.27 KB, patch) 2010-09-25 09:54 PDT, Adam Barth	no flags	Details Formatted Diff Diff
Patch for landing (10.27 KB, patch) 2010-09-26 15:00 PDT, Adam Barth	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Adam Barth

Comment 1 2010-09-25 00:04:19 PDT

Created attachment 68813 [details] Patch

Dimitri Glazkov (Google)

Comment 2 2010-09-25 07:10:04 PDT

Comment on attachment 68813 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68813&action=review > WebCore/page/Location.idl:62 > + readonly attribute [CustomSetter] DOMString origin; If you have a [CustomSetter], shouldn't there be some code in JSLocationCustom/V8LocationCustom?

Adam Barth

Comment 3 2010-09-25 09:17:05 PDT

I should remove that attribute since there is no setter.

Adam Barth

Comment 4 2010-09-25 09:54:44 PDT

Created attachment 68828 [details] Patch

Dimitri Glazkov (Google)

Comment 5 2010-09-25 10:12:33 PDT

Comment on attachment 68828 [details] Patch looks great!

WebKit Commit Bot

Comment 6 2010-09-25 11:32:27 PDT

Comment on attachment 68828 [details] Patch Rejecting patch 68828 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'build-and-test', '--no-clean', '--no-update', '--test', '--quiet', '--non-interactive']" exit_code: 2 Last 500 characters of output: All tests successful. Files=14, Tests=304, 1 wallclock secs ( 0.73 cusr + 0.16 csys = 0.89 CPU) Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Projects/CommitQueue/LayoutTests Testing 21370 test cases. fast/dom/prototype-inheritance-2.html -> failed Exiting early after 1 failures. 6728 tests run. 112.73s total testing time 6727 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 1 test case (<1%) had stderr output Full output: http://queues.webkit.org/results/4074111

Adam Barth

Comment 7 2010-09-26 15:00:31 PDT

Created attachment 68860 [details] Patch for landing

WebKit Commit Bot

Comment 8 2010-09-26 15:23:10 PDT

Comment on attachment 68860 [details] Patch for landing Clearing flags on attachment: 68860 Committed r68354: <http://trac.webkit.org/changeset/68354>

WebKit Commit Bot

Comment 9 2010-09-26 15:23:15 PDT

All reviewed patches have been landed. Closing bug.

WebKit Review Bot

Comment 10 2010-09-26 15:44:43 PDT

http://trac.webkit.org/changeset/68354 might have broken Qt Linux Release

Note You need to log in before you can comment on or make changes to this bug.