| Summary: | [Qt] New input style for Qt Mobile theme | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ragner Magalhaes <ragner.magalhaes> | ||||||||||||
| Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | ademar, diegohcg, henry.haverinen, kenneth, luiz, tonikitoo | ||||||||||||
| Priority: | P2 | Keywords: | Qt | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | Other | ||||||||||||||
| OS: | Linux | ||||||||||||||
| Bug Depends on: | |||||||||||||||
| Bug Blocks: | 46349 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Ragner Magalhaes
2010-09-24 06:52:01 PDT
Created attachment 68703 [details]
Adds web style for Maemo6 platform
This patch just adjusts the input styles for maemo6.
In other patch I will adjust the missing styles for buttons(check, radio), selects, etc.
Created attachment 68704 [details]
Maemo6 input style(patch result)
Maybe we could have just one theme instead of having different ones for each maemo version. It could be the mobile theme instead of maemo theme. (In reply to comment #3) > Maybe we could have just one theme instead of having different ones for each maemo version. > > It could be the mobile theme instead of maemo theme. You mean, the same css for maemo 5 and 6? Is possible to detect the platform in the css? If so, could be a good way (In reply to comment #4) > (In reply to comment #3) > > Maybe we could have just one theme instead of having different ones for each maemo version. > > > > It could be the mobile theme instead of maemo theme. > > You mean, the same css for maemo 5 and 6? Is possible to detect the platform in the css? If so, could be a good way No. I am talking about having the same appearance in them all. One mobile theme to all devices. (In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #3) > > > Maybe we could have just one theme instead of having different ones for each maemo version. > > > > > > It could be the mobile theme instead of maemo theme. > > > > You mean, the same css for maemo 5 and 6? Is possible to detect the platform in the css? If so, could be a good way > > No. I am talking about having the same appearance in them all. One mobile theme to all devices. So, Does the new style for maemo6 should replace the maemo5's styles? Because, for example, the input styles are different for each maemo version. Created attachment 68825 [details]
Adjust Maemo5 style to new Qt Mobile style
Mameo? That seems wrong. Also the changelog doesn't say what it is going at all, which means that this patch will never be r+'ed in its current state. Did you mean to put it up for review? if so, set the r? flag (In reply to comment #8) > Mameo? That seems wrong. Also the changelog doesn't say what it is going at Yes, that is wrong ... all, which means that this patch will never be r+'ed in its current state. > > Did you mean to put it up for review? if so, set the r? flag I didn't put it for review because I just want to get some comments from INdT team ... and fix some mistake before. Hum... Is symbian going to use it as well? If no, I would just say 'maemo' not 'mobile'? (In reply to comment #10) > Hum... Is symbian going to use it as well? If no, I would just say 'maemo' not 'mobile'? Hum .. That sounds good for me :), I will check about ... (In reply to comment #10) > Hum... Is symbian going to use it as well? If no, I would just say 'maemo' not 'mobile'? It is using it today I believe... If they want something different that can be another task. Also, it looks like the patch didnt do a proper move, it says Removed and Added, not Moved. (In reply to comment #12) > (In reply to comment #10) > > Hum... Is symbian going to use it as well? If no, I would just say 'maemo' not 'mobile'? > > It is using it today I believe... If they want something different that can be another task. > > Also, it looks like the patch didnt do a proper move, it says Removed and Added, not Moved. Humm ... I will use -M option to detect renames in the next "format-patch" and adjust the ChangeLog QT = QuickTime :-) Created attachment 68904 [details]
Proposed patch 03
Comment on attachment 68904 [details] Proposed patch 03 Clearing flags. Patch landed at r68393 Created attachment 68950 [details]
Screenshot with raster
Should this be cherry-picked to QtWebKit 2.1? (In reply to comment #18) > Should this be cherry-picked to QtWebKit 2.1? Maybe we should wait until the theme is complete. At this point just text input elements are customized. Ragner still working in buttons, checks, radios and combos. Revision r68393 cherry-picked into qtwebkit-2.1 with commit fd20b0a <http://gitorious.org/webkit/qtwebkit/commit/fd20b0a> I've also cherry-picked r68035 (3d45725), a trivial change which was needed for this fix <http://gitorious.org/webkit/qtwebkit/commit/3d45725> |