Bug 4645

Summary: collector.cpp win portability fixes
Product: WebKit Reporter: Krzysztof Kowalczyk <kkowalczyk>
Component: JavaScriptCoreAssignee: Darin Adler <darin>
Status: VERIFIED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
collector.cpp darin: review-

Krzysztof Kowalczyk
Reported 2005-08-24 23:40:33 PDT
win implementation of threading and fixes for GC
Attachments
collector.cpp (4.89 KB, patch)
2005-08-24 23:40 PDT, Krzysztof Kowalczyk 		darin: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Krzysztof Kowalczyk
Comment 1 2005-08-24 23:40:49 PDT
Created attachment 3572 [details] collector.cpp
Darin Adler
Comment 2 2005-09-03 17:37:36 PDT
Comment on attachment 3572 [details] collector.cpp I'm not going to enable multiple threads on Windows unless we know a reason that feature is needed. That's a special requirement of JavaScriptCore on Mac OS X that I don't expect on other platforms. Although I could be convinced otherwise.
Darin Adler
Comment 3 2005-09-03 18:16:15 PDT
These problems should all be fixed, but I haven't tried compiling on Windows. Krzysztof, please let me know if any of the changes don't work.
Note You need to log in before you can comment on or make changes to this bug.