Bug 46449

Summary: REGRESSION(r68236): compile fix didn't work (Requested by dino___ on #webkit).
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: WebKit Review Bot <webkit.review.bot>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, hans, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 46344    
Attachments:
Description Flags
ROLLOUT of r68236 none

WebKit Review Bot
Reported 2010-09-23 23:23:36 PDT
http://trac.webkit.org/changeset/68236 broke the build: compile fix didn't work (Requested by dino___ on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear
Attachments
ROLLOUT of r68236 (51.58 KB, patch)
2010-09-23 23:23 PDT, WebKit Review Bot 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
WebKit Review Bot
Comment 1 2010-09-23 23:23:49 PDT
Created attachment 68652 [details] ROLLOUT of r68236 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID --ignore-builders where ATTACHMENT_ID is the ID of this attachment.
WebKit Review Bot
Comment 2 2010-09-24 00:34:52 PDT
Comment on attachment 68652 [details] ROLLOUT of r68236 Rejecting patch 68652 from commit-queue. caseq@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
WebKit Commit Bot
Comment 3 2010-09-24 01:02:55 PDT
Comment on attachment 68652 [details] ROLLOUT of r68236 Clearing flags on attachment: 68652 Committed r68241: <http://trac.webkit.org/changeset/68241>
WebKit Commit Bot
Comment 4 2010-09-24 01:03:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.