Summary: | Unskip remaining canvas layout tests so that they can track progressions/regressions | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Matthew Delaney <mdelaney7> | ||||||||||
Component: | Canvas | Assignee: | Matthew Delaney <mdelaney7> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | abarth, adele, commit-queue, darin, eric, mdelaney7, oliver, ossy, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | PC | ||||||||||||
OS: | OS X 10.5 | ||||||||||||
Attachments: |
|
Description
Matthew Delaney
2010-09-23 17:43:28 PDT
Created attachment 68632 [details]
Patch
Are there opened bugs for fixing these failing? Yes and no. There is one master bug opened to "pass them all" and then at least a few tracking individual failing tests. We should definitely open bugs for each though. Comment on attachment 68632 [details]
Patch
I agree this makes sense to unskip these. Please file individual bugs for the tests that have failing expected results, so we don't lose track of them.
I created this master bug (https://bugs.webkit.org/show_bug.cgi?id=46506) that will depend on all of the individual bugs filed per test. In the process of filing all those. Comment on attachment 68632 [details] Patch Clearing flags on attachment: 68632 Committed r68568: <http://trac.webkit.org/changeset/68568> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/68568 might have broken Qt Linux Release The following changes are on the blame list: http://trac.webkit.org/changeset/68568 http://trac.webkit.org/changeset/68566 http://trac.webkit.org/changeset/68567 (In reply to comment #8) > http://trac.webkit.org/changeset/68568 might have broken Qt Linux Release > The following changes are on the blame list: > http://trac.webkit.org/changeset/68568 > http://trac.webkit.org/changeset/68566 > http://trac.webkit.org/changeset/68567 Qt buildbot don't like this patch, because the following tests pass: canvas/philip/tests/2d.gradient.radial.cone.front.html canvas/philip/tests/2d.gradient.radial.inside2.html canvas/philip/tests/2d.gradient.radial.inside3.html canvas/philip/tests/2d.gradient.radial.outside1.html canvas/philip/tests/2d.line.cap.closed.html canvas/philip/tests/2d.line.join.parallel.html canvas/philip/tests/2d.shadow.enable.blur.html canvas/philip/tests/2d.shadow.enable.x.html canvas/philip/tests/2d.shadow.enable.y.html canvas/philip/tests/2d.shadow.gradient.alpha.html canvas/philip/tests/2d.shadow.gradient.basic.html canvas/philip/tests/2d.shadow.gradient.transparent.2.html canvas/philip/tests/2d.strokeRect.zero.4.html canvas/philip/tests/toDataURL.jpeg.alpha.html Qt specific expected files landed for passing tests in http://trac.webkit.org/changeset/68633 (In reply to comment #8) > http://trac.webkit.org/changeset/68568 might have broken Qt Linux Release > The following changes are on the blame list: > http://trac.webkit.org/changeset/68568 > http://trac.webkit.org/changeset/68566 > http://trac.webkit.org/changeset/68567 Dear Matthew and Adele, please don't ignore this kind of notices. We usually fix what we break and don't leave the tree burning. It looks like this broke canvas/philip/tests/toDataURL.jpeg.alpha.html on Snow Leopard. This was a very Mac-centric patch. Why not check in mac-specific results for these? I expect a number of these tests are related to canvas on CG systems. We could just roll this out, since the landing was actually done by the commit-queue. I think the failure in this patch was not considering all platforms. Canvas is sadly rather graphics-library specific. canvas/philip/tests/2d.imageData.get.source.outside.html is failing on Leopard too. If the commit-bot landed this, then all the tests must have passed for it on either leopard or snow leopard (we have nodes of both OSes and its' random which one you get). So one of these failures must be flaky. It was landed by a Snow Leopard bot: https://webkit-commit-queue.appspot.com/results/4210003 (you can tell by the python version). https://webkit-commit-queue.appspot.com/patch/68632 also shows the the tests flaked once before the land completed correctly. So it seems this added a flaky test too. I'm going to roll this out, especially since I feel partially responsible as the cq-admin. We can roll this back in when someone is around to deal with the tree fires. Reverted r68568 for reason: Failing tests on both Leopard and Snow Leopard Committed r68737: <http://trac.webkit.org/changeset/68737> http://trac.webkit.org/changeset/68737 might have broken SnowLeopard Intel Release (Tests) Currently preparing a patch to add the expected results to the proper locations and unskip the appropriate tests - so as to not mess up the other ports. Sorry about that! *** Bug 46830 has been marked as a duplicate of this bug. *** Created attachment 69395 [details]
Unskip canvas layout tests / update platform expectations
Unskips all but two of the remaining philip canvas layout tests and adds in the mac platform specific results.
Created attachment 69400 [details]
Unskip canvas layout tests / update platform expectations
Unskips all but two of the remaining philip canvas layout tests and adds in the mac platform specific results.
Comment on attachment 69400 [details]
Unskip canvas layout tests / update platform expectations
Let's give the commit queue another go at this.
Comment on attachment 69400 [details] Unskip canvas layout tests / update platform expectations Rejecting patch 69400 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'apply-attachment', '--force-clean', '--non-interactive', '--quiet', 69400]" exit_code: 2 Cleaning working directory Updating working directory Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=69400&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=46439&ctype=xml Processing 1 patch from 1 bug. Processing patch 69400 from bug 46439. Failed to run "[u'/Users/abarth/git/webkit-queue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Geoffrey Garen', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/4439036 The patch doesn't apply. Sorry the output is kinda lame. Created attachment 72221 [details]
Patch
Comment on attachment 72221 [details] Patch Clearing flags on attachment: 72221 Committed r70803: <http://trac.webkit.org/changeset/70803> All reviewed patches have been landed. Closing bug. |