Summary: | Skia image decoder needs to check whether bitmap copying succeeded | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Peter Kasting <pkasting> | ||||||
Component: | WebCore Misc. | Assignee: | Peter Kasting <pkasting> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | ||||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | All | ||||||||
URL: | http://asset.soup.io/asset/1056/8367_7835_48-square.gif | ||||||||
Attachments: |
|
Description
Peter Kasting
2010-09-23 17:36:09 PDT
Created attachment 68638 [details]
patch v1
The only bad thing about this patch is that the layout test waits for 15 seconds. This was because the test case took anywhere from 7 to 11 seconds to crash on my Dev channel build of Chrome. I'm not sure how to speed this up :(
Hmm... another problem is that I bet non-Skia platforms that use the open-source image decoders will crash on this testcase once it runs them out of RAM. Maybe I should make the layout test a manual test instead? Created attachment 68954 [details]
patch v2
This makes the test a manual test at dglazkov's suggestion.
I also fixed a missing resource in a similar test while I was at it. I can commit that part separately, but I threw it in here so I could get two r+s for the price of one.
Comment on attachment 68954 [details]
patch v2
R=me. Please make sure the images aren't svn:executable before landing.
|