Bug 46428

Summary: [chromium] add baselines for no-caret-repaint-in-non-content-editable-element.html
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: atwilson, dglazkov, levin, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch dglazkov: review+

Tony Chang
Reported 2010-09-23 16:25:02 PDT
[chromium] add baselines for no-caret-repaint-in-non-content-editable-element.html
Attachments
Patch (25.03 KB, patch)
2010-09-23 16:25 PDT, Tony Chang 		dglazkov: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2010-09-23 16:25:30 PDT
Created attachment 68616 [details] Patch
Tony Chang
Comment 2 2010-09-23 16:30:48 PDT
This test started passing in DRT after http://trac.webkit.org/changeset/68191 . I was waiting for the DRT bots to run so I could grab the baselines from the tree. The only difference on Windows & Linux are the font metrics and Mac seems to match except for overlay color (I think this is ok for repaint tests, right?).
Dimitri Glazkov (Google)
Comment 3 2010-09-23 16:41:29 PDT
Comment on attachment 68616 [details] Patch yup.
Tony Chang
Comment 4 2010-09-23 17:01:44 PDT
Committed r68218: <http://trac.webkit.org/changeset/68218>
Andrew Wilson
Comment 5 2010-09-23 18:05:09 PDT
Are these baselines correct? I'm seeing these tests go red on the canary bots.
Tony Chang
Comment 6 2010-09-23 18:09:49 PDT
Sorry, I had the expectation wrong. It should have been TEXT, but I had IMAGE+TEXT. I've fixed it in http://trac.webkit.org/changeset/68224. The test won't pass in test_shell until http://codereview.chromium.org/3442014/show lands.
Note You need to log in before you can comment on or make changes to this bug.