Bug 46418
| Summary: | Make flexible boxes work with vertical text. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Dave Hyatt <hyatt> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | ASSIGNED | ||
| Severity: | Normal | CC: | ahmad.saleem792, rreno, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar, WPTImpact |
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
| Bug Depends on: | 46473 | ||
| Bug Blocks: | 46123 | ||
Dave Hyatt
Make flexible boxes work with vertical text.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Dave Hyatt
https://bugs.webkit.org/show_bug.cgi?id=46442... have to remove that code for flexible boxes eventually.... once we know how flexible boxes are supposed to work...
Adele Peterson
<rdar://problem/8612059>
Tim Nguyen (:ntim)
Relevant WPT: https://wpt.fyi/results/css/css-flexbox/webkit-box-vertical-writing-mode.html?label=master&label=experimental&product=chrome&product=firefox&product=safari&aligned&q=css%2Fcss-flexbox%2Fwebkit-box-vertical-writing-mode.html
Ryan Reno
I took a shot at this. RenderDeprecatedFlexibleBox is actually quite simple. To determine whether or not to do vertical or horizontal layout it just checks if the box has BoxOrient::Horizontal or not.
I tried using RenderObject::isHorizontalWritingMode to make that check for vertical or horizontal flow more similar to other standardized Renderers. However, it looks like the RenderObject bitfields are being set to horizontal writing mode no matter what CSS writing-mode value is specified.
So it's going to be slightly less easy than I initially thought.